-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NRBF] skip the most time-consuming test case for non-Release builds to avoid timeouts for checked builds #110550
Conversation
@@ -20,10 +20,15 @@ public NonSeekableStream(byte[] buffer) : base(buffer) { } | |||
|
|||
public static IEnumerable<object[]> GetCanReadArrayOfAnySizeArgs() | |||
{ | |||
foreach (int size in new[] { 1, 127, 128, 512_001, 512_001 }) | |||
foreach (int size in new[] { 1, 127, 128, 512_001 }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is 512_001
particularly interesting value to test for some reason?
Would it be simpler to just change 512_001
to something smaller, like 20_001
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing in particular, I am going to apply your suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
I was not able to reproduce a timeout, but I was able to notice that it takes a LOT of time to run (more than 10 minutes on a really beefy PC). I've attached a profiler and found the test case which was executing the worst case scenario (non-seekable stream from which we read 512k bytes one by one).
The command I've used after building the repo:
fixes #110285