-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] Remove WASM HybridGlobalization
from library tests, WBT and docs
#110534
Merged
ilonatommy
merged 11 commits into
dotnet:main
from
ilonatommy:remove-hg-feature-on-wasm
Dec 11, 2024
Merged
[browser] Remove WASM HybridGlobalization
from library tests, WBT and docs
#110534
ilonatommy
merged 11 commits into
dotnet:main
from
ilonatommy:remove-hg-feature-on-wasm
Dec 11, 2024
+212
−4,832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilonatommy
added
arch-wasm
WebAssembly architecture
area-System.Globalization
os-browser
Browser variant of arch-wasm
labels
Dec 9, 2024
ilonatommy
requested review from
maraf,
lewing and
pavelsavara
as code owners
December 9, 2024 15:09
ilonatommy
changed the title
[browser] Remove
[browser] Remove WASM Dec 9, 2024
HybridGlobalization
from library tests, WBT and docsHybridGlobalization
from library tests, WBT and docs
ilonatommy
force-pushed
the
remove-hg-feature-on-wasm
branch
from
December 10, 2024 10:43
8b30633
to
62082a0
Compare
3 tasks
Failures of |
This was referenced Dec 10, 2024
javiercn
approved these changes
Dec 11, 2024
3 tasks
hez2010
pushed a commit
to hez2010/runtime
that referenced
this pull request
Dec 14, 2024
…nd docs (dotnet#110534) * Remove `HybridGlobalization` from library tests. * Remove `HybridGlobalization` from WBT. * Remove docs about HG on WASM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
arch-wasm
WebAssembly architecture
area-System.Globalization
os-browser
Browser variant of arch-wasm
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected PR: #110526.
Closes #95503 (active issues with this bug got removed).
There will be another PR with the removal of
HybridGlobalization
code from the runtime. Because this one was already pretty big, I decided to make it in a follow-up.