JIT: remove is rare check from finally cloning #110483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are currently few rarely run finallys, so stop checking for them. Future changes may introduce some, and cloning them can be beneficial to nearby hot code.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
@amanasifkhalid PTAL No SPMI diffs (at least win x64). Will be useful for de-abstraction work. |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
amanasifkhalid
approved these changes
Dec 6, 2024
| JITDUMP("Finally in EH#%u is run rarely; skipping.\n", XTnum); | ||
| continue; | ||
| } | ||
|
|
||
| // Empirical studies from CoreCLR and CoreFX show that less |
There was a problem hiding this comment.
Unrelated to this PR, but it might be interesting to revisit comments like these by looking at some JIT metrics.
There was a problem hiding this comment.
Yes, that is on my todo list ...
This was referenced Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently few rarely run finallys, so stop checking for them. Future changes may introduce some, and cloning them can be beneficial to nearby hot code.