Remove Helper Method Frames (HMF) from Reflection #110481
Merged
+164
−175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @mangod9 |
This was referenced Dec 6, 2024
am11
reviewed
Dec 6, 2024
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Adeel Mujahid <[email protected]>
jkotas
reviewed
Dec 9, 2024
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs
Outdated
Show resolved
Hide resolved
|
armel failure is unrelated (toolchain got updated in the latest image build when we removed libgdiplus). Fixed by #110514. |
jkotas
reviewed
Dec 9, 2024
src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs
Outdated
Show resolved
Hide resolved
This was referenced Dec 9, 2024
Open
hez2010
pushed a commit
to hez2010/runtime
that referenced
this pull request
Dec 14, 2024
Convert RuntimeTypeHandle.GetFields() to QCall. Convert RuntimeTypeHandle.GetInterfaces() to QCall. Convert Signature.CompareSig() to QCall. Rename to Signature.CompareSig() to Signature.AreEqual(). --------- Co-authored-by: Adeel Mujahid <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert
RuntimeTypeHandle.GetFields()to QCall.Convert
RuntimeTypeHandle.GetInterfaces()to QCall.Convert
Signature.CompareSig()to QCall.Rename to
Signature.CompareSig()toSignature.AreEqual().