Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JIT_LMul optimization #110467

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix JIT_LMul optimization #110467

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
453ce17
Fix JIT_LMul optimization
am11 Dec 6, 2024
345bf3e
Simplify to regular multiplication
am11 Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions src/coreclr/vm/jithelpers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,6 @@ using std::isnan;

#include <optsmallperfcritical.h>

//
// helper macro to multiply two 32-bit uints
//
#define Mul32x32To64(a, b) ((UINT64)((UINT32)(a)) * (UINT64)((UINT32)(b)))

//
// helper macro to get high 32-bit of 64-bit int
//
Expand All @@ -116,12 +111,6 @@ HCIMPL2_VV(INT64, JIT_LMul, INT64 val1, INT64 val2)
{
FCALL_CONTRACT;

UINT32 val1High = Hi32Bits(val1);
UINT32 val2High = Hi32Bits(val2);

if ((val1High == 0) && (val2High == 0))
return Mul32x32To64(val1, val2);

return (val1 * val2);
}
HCIMPLEND
Expand Down
Loading