Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Remove DiagnosticSource reference from Microsoft.Extensions.Logging.Abstractions #110458

Open
wants to merge 1 commit into
base: release/8.0-staging
Choose a base branch
from

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Dec 5, 2024

Fixes #110401

Customer Impact

  • Customer reported
  • Found internally

Unnecessary unused dependency added on <= net7.0, .netstandard, .netframework with the following impact to customer:

  • Requires more bindingRedirects
  • Increased application size (185 KB)
  • Additional license implications

Regression

  • Yes (regressed in 8.0.2 compared to 8.0.1)
  • No

Testing

Build to validate unused dependency is removed.

Risk

Very low. Removing an unused dependency that's only shipped in one release.

…bstractions

This was inadvertently added in backport but was not needed.
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

@carlossanlop carlossanlop added the Servicing-consider Issue for next servicing release review label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Extensions-Logging Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants