-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix wrong arguments order in CrlCacheExpired call #110457
Conversation
Arguments nextUpdate and verificationTime should be passed in different order
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
Hi @Alex4414 .NET Team has reached this time of the year where most of us are already offline enjoying their winter holidays. I'll try to find a reviewer offline, but I can't promise anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@krwq thanks, and who can merge PR? |
@Alex4414 relax! area owner will merge it when they are available |
@Alex4414 the merge button is grayed out until all CI checks are complete and green, it was still running when I approved |
Arguments nextUpdate and verificationTime should be passed in different order
Arguments nextUpdate and verificationTime should be passed in different order. Signature of OpenSslX509ChainEventSource.CrlCacheExpired:
internal void CrlCacheExpired(DateTime verificationTime, DateTime nextUpdate)
Found by Linux Verification Center (linuxtesting.org) with SVACE.