Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong arguments order in CrlCacheExpired call #110457

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

Alex4414
Copy link
Contributor

@Alex4414 Alex4414 commented Dec 5, 2024

Arguments nextUpdate and verificationTime should be passed in different order. Signature of OpenSslX509ChainEventSource.CrlCacheExpired:

internal void CrlCacheExpired(DateTime verificationTime, DateTime nextUpdate)

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Arguments nextUpdate and verificationTime should be passed in different order
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Dec 5, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

@Alex4414
Copy link
Contributor Author

Alex4414 commented Dec 6, 2024

Helllo, @bartonjs, @vcsjones can you review PR?

@Alex4414
Copy link
Contributor Author

@bartonjs @vcsjones any news?

@adamsitnik
Copy link
Member

Hi @Alex4414

.NET Team has reached this time of the year where most of us are already offline enjoying their winter holidays.

I'll try to find a reviewer offline, but I can't promise anything.

Copy link
Member

@krwq krwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alex4414
Copy link
Contributor Author

@krwq thanks, and who can merge PR?

@kasperk81
Copy link
Contributor

@Alex4414 relax! area owner will merge it when they are available

@krwq krwq merged commit da51e02 into dotnet:main Dec 11, 2024
83 checks passed
@krwq
Copy link
Member

krwq commented Dec 11, 2024

@Alex4414 the merge button is grayed out until all CI checks are complete and green, it was still running when I approved

hez2010 pushed a commit to hez2010/runtime that referenced this pull request Dec 14, 2024
Arguments nextUpdate and verificationTime should be passed in different order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Security community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants