Fix for "ld.lld: error: undefined symbol: _Uaarch64_setcontext" when doing build for FreeBSD-arm64 using internal libunwind #110432
Conversation
…doing build for arm64 using internal libunwind
dotnet-issue-labeler
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
src/native/external/libunwind.cmake
Outdated
| @@ -96,7 +96,7 @@ elseif(CLR_CMAKE_TARGET_FREEBSD) | |||
| set(libunwind_la_SOURCES_arm_os arm/Gos-freebsd.c) | |||
| set(libunwind_la_SOURCES_arm_os_local arm/Los-freebsd.c) | |||
| set(libunwind_la_SOURCES_aarch64_os aarch64/Gos-freebsd.c) | |||
| set(libunwind_la_SOURCES_aarch64_os_local aarch64/Los-freebsd.c) | |||
| set(libunwind_la_SOURCES_aarch64_os_local aarch64/Los-freebsd.c aarch64/setcontext.S) | |||
There was a problem hiding this comment.
We need both (only setcontext.S was missing)
| set(libunwind_la_SOURCES_aarch64_os_local aarch64/Los-freebsd.c aarch64/setcontext.S) | |
| set(libunwind_la_SOURCES_aarch64_os_local aarch64/Los-freebsd.c) | |
| set(libunwind_aarch64_la_SOURCES_os aarch64/setcontext.S) |
There was a problem hiding this comment.
Isn't what my change set(libunwind_la_SOURCES_aarch64_os_local aarch64/Los-freebsd.c aarch64/setcontext.S) is doing? Am I wrong, that second set will overwrite the previous one? So it's just ok to add aarch64/setcontext.S to the existing line with set?
There was a problem hiding this comment.
Ah, corrected the patch. Lets put them on separate lines for consistency.
There was a problem hiding this comment.
I meant keep the existing style used in this file (one line added, zero removed).
There was a problem hiding this comment.
Sorry I'm lost - there are few ways of doing set in this file. It's not possible to only add one line in here, as there's matching bracket on the line end when calling set, and this needs to go into the same variable which is included later?
There was a problem hiding this comment.
The naming convention here is taken from libunwind, how they classify these files. Source are arch specific, others are OS specific and then few are machine independent (mi). Using the existing convention, that will become main...am11:runtime:patch-24.
Two lines because this is the first assembly file in aarch64 group. :)
There was a problem hiding this comment.
Ok, wasn't feeling good last days, now should be ok..
am11
added
area-PAL-coreclr
and removed
needs-area-label
| @@ -229,7 +230,7 @@ set(libunwind_la_SOURCES_aarch64_common | |||
| # The list of files that go into libunwind: | |||
| set(libunwind_la_SOURCES_aarch64 | |||
| ${libunwind_la_SOURCES_aarch64_common} | |||
| ${libunwind_la_SOURCES_aarch64_os_local} | |||
| ${libunwind_la_SOURCES_aarch64_os_local} ${libunwind_aarch64_la_SOURCES_os} | |||
There was a problem hiding this comment.
Why is the aarch64/setcontext.S added only for FreeBSD and the getcontext.S for all targets? For other architectures, both are added for all targets.
There was a problem hiding this comment.
@janvorli, getsetcontext is for x86 arch only and applies to Linux and FreeBSD OS alike.
FreeBSD aarch64 requirement was added in 1.8 libunwind/libunwind@032abaa. Linux aarch64 does not require it. I think we should make it clear by adding a column "OS" to the table in their readme https://github.com/libunwind/libunwind?tab=readme-ov-file#libc-requirements
There was a problem hiding this comment.
Ah, thank you for the details, that makes sense.
Enable runtime build under FreeBSD-arm64 when using internal libunwind (atm. port version have bug that crash sdk randomly). Setting
CLR_CMAKE_USE_SYSTEM_LIBUNWIND 0produce working SDK. cc @am11 for the tip.