Fix length check for Convert.TryToHexString{Lower} #109891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The size of destination should not be less than double source's length. Fix #109807
dotnet-policy-service
bot
added
the
community-contribution
|
@dotnet-policy-service agree |
huoyaoyuan
reviewed
Nov 17, 2024
...libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/Convert.ToHexString.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Nov 17, 2024
...libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/Convert.ToHexString.cs
Outdated
Show resolved
Hide resolved
This was referenced Nov 19, 2024
Open
3 tasks
adamsitnik
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
LGTM, @universorum big thanks for providing the fix and adding excellent tests!
|
/backport to release/9.0-staging |
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/12054838800 |
4 tasks
mikelle-rogers
pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
The size of destination should not be less than double source's length. Fix dotnet#109807
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size of destination should not be less than double source's length.
Fix #109807