Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name of MonoAOTOffsets artifact in runtime.yml #109797

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

akoeplinger
Copy link
Member

To match the message in the build log, see #109363 (comment)

To match the message in the build log, see #109363 (comment)
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 13, 2024
@@ -754,7 +754,7 @@ extends:

- publish: '$(Build.SourcesDirectory)/artifacts/obj/mono/offsetfiles'
condition: failed()
artifact: Mono_Offsets_$(osGroup)$(osSubGroup)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to change the artifact name in any corresponding download step?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no this isn't downloaded by the build anymore, just by humans updating the checked-in files.

@akoeplinger
Copy link
Member Author

/ba-g timeout is unrelated.

@akoeplinger akoeplinger merged commit 8d21e13 into main Nov 13, 2024
145 of 147 checks passed
@akoeplinger akoeplinger deleted the akoeplinger-patch-2 branch November 13, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants