-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set TargetsLinuxGlibc to false on Android #109649
base: main
Are you sure you want to change the base?
Conversation
It's not using glibc. One could argue that we should set TargetsLinuxBionic=true on Android but that'd go against how we used that name elsewhere.
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Where would it break? I have spot checked a few places and it seems to be fine. It would allow us to simplify |
Yeah I'd assume that Android implies Linux Bionic and for the small number of cases where that differs, we'd check "Linux Bionic and not Android" |
Example breakages:
Those can be fixed of course and I don't really feel strongly one way or another but we need to be careful. |
I think I prefer fixing TargetsLinuxBionic=true on Android instead, the number of places where it matters is indeed quite small. I'll update the PR (not today since it's almost weekend here 😄) |
It's not using glibc. One could argue that we should set TargetsLinuxBionic=true on Android but that'd go against how we used that name elsewhere.
Follow-up to #109526