[cdac] cleanup tests in a few ways #109357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update ExecutionManagerTestBuilder to allocate 1-byte aligned data (same as old BumpAllocator behavior) for the "jitted code" page
….Builder arg can get the helpers from the builder instead
more instance methods
… with alignment The ExceptionInfo is actually placed right in the Thread object when funclets aren't in use. So we don't want the bump allocator to do 2 separate allocations with a hole in between. (which is what the default 16-byte alignment was leaving)
dotnet-issue-labeler
bot
added
the
needs-area-label
lambdageek
removed
the
needs-area-label
|
Tagging subscribers to this area: @tommcdon |
lambdageek
commented
Oct 29, 2024
elinor-fung
approved these changes
Oct 29, 2024
Co-Authored-By: Elinor Fung <[email protected]>
This was referenced Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RuntimeTypeSystem_1into separate helpers. In particular move the MethodTable validation logic out. This is in preparation for doing MethodDesc unit testing so that we don't have to create fully realized MethodTables just to test the method descriptor logic