Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cdac] Implement IXCLRDataTask::CreateStackWalk #109350

Merged
merged 5 commits into from
Oct 30, 2024

Conversation

elinor-fung
Copy link
Member

  • Add ClrDataStackWalk to cDAC as its implementation of IXCLRDataStackWalk
    • Currently delegates everything to legacy implementation
  • Implement IXCLRDataTask::CreateStackWalk
    • Checks that the thread has been started
    • Gets the result from the legacy DAC and passes it to the cDAC ClrDataStackWalk
  • Switch ISOSDacInterface.GetModule to use out IXCLRDataModule? instead of void**

Contributes to #108553

cc @AaronRobinsonMSFT @davidwrighton

Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@elinor-fung elinor-fung merged commit a72cfb0 into dotnet:main Oct 30, 2024
148 checks passed
@elinor-fung elinor-fung deleted the cdac-xclrdatastackwalk branch October 30, 2024 20:22
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants