Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward NetCoreAppToolCurrentVersion in DotNetBuild.props #109331

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Forward NetCoreAppToolCurrentVersion in DotNetBuild.props #109331

merged 3 commits into from
Oct 30, 2024

Conversation

ViktorHofer
Copy link
Member

Replaces #109265
Needed for dotnet/sdk#43015

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@ViktorHofer ViktorHofer changed the title Forward NetCoreAppToolCurrent in DotNetBuild.props Forward NetCoreAppToolCurrentVersion in DotNetBuild.props Oct 29, 2024
@build-analysis build-analysis bot mentioned this pull request Oct 29, 2024
Open
@jkotas
Copy link
Member

jkotas commented Oct 29, 2024

You can also revert #108946 as part of this fix.

jkotas
jkotas approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - assuming that it works

@jkotas jkotas mentioned this pull request Oct 29, 2024
Closed
@ViktorHofer
Revert "Allow the cdac build tool to roll forward to whatever SDK is …
9603569 
…available (prerelease or otherwise) (#108946)"

This reverts commit 2cbc23a.
@ViktorHofer ViktorHofer merged commit 1557f12 into main Oct 30, 2024
148 checks passed
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-2 branch October 30, 2024 06:45
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@jkotas jkotas jkotas approved these changes

Assignees

@ViktorHofer ViktorHofer

Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ViktorHofer @jkotas @jkoritzinsky