Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump TraceEvent package version #109192

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Conversation

mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Oct 24, 2024

Fixes #107315

This PR aims to bump the TraceEvent package version to include the changes introduced by microsoft/perfview#2111 which prevents "System.Private.CoreLib" module names associated with TraceEvents from being incorrectly trimmed to "System.Private".

@mdh1418
Copy link
Member Author

mdh1418 commented Oct 28, 2024

It looks like the profiler runtime tests are failing because of a project reference issue. After bumping to a newer TraceEvent library, the Microsoft.Diagnostics.NETCore.Client assembly references are no longer making it to the profiler test's directory

Left side with TraceEvent version bump vs. Right side without TraceEvent version bump
Screenshot 2024-10-28 135815

I'm not exactly sure what is preventing Microsoft.Diagnostics.NETCore.Client from being copied into the test directory, but my current suspicion is that Microsoft.Diagnostics.Tracing.TraceEvent began depending on Microsoft.Diagnostics.NETCore.Client sometime after version 3.1.7 because of microsoft/perfview#1867, so building with a TraceEvent package that contains that reference will cause two Dependencies on Microsoft.Diagnostics.NETCore.Client (one with version 0.0.0.0 and another with version 0.2.10.10501), where the latter will prevail.

Screenshot 2024-10-28 140451

@hoyosjs Do you have any ideas on how to fix this?

@hoyosjs
Copy link
Member

hoyosjs commented Oct 29, 2024

Easiest one is to always assign a high version to the in-tree one and say that one needs to be backward compatible with the one referenced in tests (and it's closure)

@mdh1418 mdh1418 force-pushed the bump_trace_event_version branch 2 times, most recently from 943b428 to 267f62a Compare November 11, 2024 19:52
@mdh1418 mdh1418 force-pushed the bump_trace_event_version branch from 267f62a to 2534a00 Compare November 12, 2024 20:56
@mdh1418 mdh1418 merged commit 099bf1e into dotnet:main Nov 14, 2024
156 checks passed
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
* Bump TraceEvent package version

* Prioritize in-tree Microsoft.Diagnostics.NETCore.Client
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mono] NetTrace Collected mismatches expected CLR Instance name
3 participants