Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RISC-V] Increase timeouts in System.Text.Json.Serialization.Tests.OptionsTests #108702

Closed
wants to merge 6 commits into from
Closed

[RISC-V] Increase timeouts in System.Text.Json.Serialization.Tests.OptionsTests #108702

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
25e9e82
extend timeout in Options_RespectRequiredConstructorParameters_Featur…
sirntar Oct 9, 2024
43beafe
Merge branch 'main' into extend-timeout-in-OptionsTests
jkotas Oct 9, 2024
61e6c39
Merge branch 'main' into extend-timeout-in-OptionsTests
sirntar Oct 28, 2024
1b14d96
Merge branch 'main' into extend-timeout-in-OptionsTests
sirntar Oct 29, 2024
0c4d1d7
increse timeouts in OptionsTests that involve RemoteExecutor
sirntar Oct 30, 2024
c520c95
Merge branch 'main' into extend-timeout-in-OptionsTests
sirntar Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/OptionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,7 +687,8 @@ public static void Options_DisablingIsReflectionEnabledByDefaultSwitch_DefaultOp
RuntimeConfigurationOptions =
{
["System.Text.Json.JsonSerializer.IsReflectionEnabledByDefault"] = false
}
},
TimeOut = RemoteExecutor.FailWaitTimeoutMilliseconds * PlatformDetection.SlowRuntimeTimeoutModifier
};

RemoteExecutor.Invoke(static () =>
Expand Down Expand Up @@ -732,7 +733,8 @@ public static void Options_DisablingIsReflectionEnabledByDefaultSwitch_NewOption
RuntimeConfigurationOptions =
{
["System.Text.Json.JsonSerializer.IsReflectionEnabledByDefault"] = false
}
},
TimeOut = RemoteExecutor.FailWaitTimeoutMilliseconds * PlatformDetection.SlowRuntimeTimeoutModifier
};

RemoteExecutor.Invoke(static () =>
Expand Down Expand Up @@ -789,7 +791,8 @@ public static void Options_DisablingIsReflectionEnabledByDefaultSwitch_CanUseSou
RuntimeConfigurationOptions =
{
["System.Text.Json.JsonSerializer.IsReflectionEnabledByDefault"] = false
}
},
TimeOut = RemoteExecutor.FailWaitTimeoutMilliseconds * PlatformDetection.SlowRuntimeTimeoutModifier
};

RemoteExecutor.Invoke(static () =>
Expand All @@ -812,7 +815,10 @@ public static void Options_DisablingIsReflectionEnabledByDefaultSwitch_CanUseSou
[InlineData(true)]
public static void Options_JsonSerializerContext_GetConverter_DoesNotFallBackToReflectionConverter(bool isCompatibilitySwitchExplicitlyDisabled)
{
var options = new RemoteInvokeOptions();
var options = new RemoteInvokeOptions
{
TimeOut = RemoteExecutor.FailWaitTimeoutMilliseconds * PlatformDetection.SlowRuntimeTimeoutModifier
};

if (isCompatibilitySwitchExplicitlyDisabled)
{
Expand Down Expand Up @@ -851,7 +857,8 @@ public static void Options_JsonSerializerContext_Net6CompatibilitySwitch_FallsBa
RuntimeConfigurationOptions =
{
["System.Text.Json.Serialization.EnableSourceGenReflectionFallback"] = true
}
},
TimeOut = RemoteExecutor.FailWaitTimeoutMilliseconds * PlatformDetection.SlowRuntimeTimeoutModifier
};

RemoteExecutor.Invoke(static () =>
Expand Down Expand Up @@ -889,7 +896,8 @@ public static void Options_JsonSerializerContext_Net6CompatibilitySwitch_IsOverr
{
["System.Text.Json.JsonSerializer.IsReflectionEnabledByDefault"] = false,
["System.Text.Json.Serialization.EnableSourceGenReflectionFallback"] = true
}
},
TimeOut = RemoteExecutor.FailWaitTimeoutMilliseconds * PlatformDetection.SlowRuntimeTimeoutModifier
};

RemoteExecutor.Invoke(static () =>
Expand Down Expand Up @@ -926,7 +934,11 @@ public static void Options_JsonSerializerContext_Combine_FallbackToReflection()
[InlineData(true)]
public static void Options_RespectNullableAnnotationsDefault_FeatureSwitch(bool? state)
{
var options = new RemoteInvokeOptions();
var options = new RemoteInvokeOptions
{
TimeOut = RemoteExecutor.FailWaitTimeoutMilliseconds * PlatformDetection.SlowRuntimeTimeoutModifier
};

if (state.HasValue)
{
options.RuntimeConfigurationOptions["System.Text.Json.Serialization.RespectNullableAnnotationsDefault"] = state.Value;
Expand Down Expand Up @@ -969,7 +981,11 @@ public static void Options_RespectNullableAnnotationsDefault_FeatureSwitch(bool?
[InlineData(true)]
public static void Options_RespectRequiredConstructorParameters_FeatureSwitch(bool? state)
{
var options = new RemoteInvokeOptions();
var options = new RemoteInvokeOptions
{
TimeOut = RemoteExecutor.FailWaitTimeoutMilliseconds * PlatformDetection.SlowRuntimeTimeoutModifier
};

if (state.HasValue)
{
options.RuntimeConfigurationOptions["System.Text.Json.Serialization.RespectRequiredConstructorParametersDefault"] = state.Value;
Expand Down