Share pthread_setname via minipal #108370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
am11
force-pushed
the
feature/illumos-port
branch
4 times, most recently
from
114d062 to
9f59c12
Compare
3 tasks
|
Should this be moved to minipal? |
|
Yes, it does seem like a good candidate for minipal. 😃 |
This was referenced Sep 29, 2024
jkotas
reviewed
Sep 29, 2024
am11
force-pushed
the
feature/illumos-port
branch
from
6621b1f to
cfd1ae2
Compare
am11
changed the title
am11
force-pushed
the
feature/illumos-port
branch
from
125dfc5 to
1c276fa
Compare
am11
force-pushed
the
feature/illumos-port
branch
from
1c276fa to
c5927f3
Compare
|
cc @jkoritzinsky, a heads-up for potential conflict with your PR. 🙈 |
am11
commented
Sep 30, 2024
| * | ||
| * @return A pointer to a null-terminated string containing the executable path, | ||
| * or NULL if an error occurs. | ||
| */ |
There was a problem hiding this comment.
aligned the documentation with utf8.h.
AaronRobinsonMSFT
approved these changes
Sep 30, 2024
jkotas
reviewed
Sep 30, 2024
This was referenced Sep 30, 2024
am11
force-pushed
the
feature/illumos-port
branch
2 times, most recently
from
b632b63 to
b6000f4
Compare
am11
force-pushed
the
feature/illumos-port
branch
4 times, most recently
from
3a2e647 to
c185356
Compare
jkotas
reviewed
Oct 1, 2024
lambdageek
reviewed
Oct 1, 2024
lambdageek
reviewed
Oct 1, 2024
lambdageek
approved these changes
Oct 1, 2024
am11
force-pushed
the
feature/illumos-port
branch
2 times, most recently
from
5fe836b to
2f6239f
Compare
am11
force-pushed
the
feature/illumos-port
branch
2 times, most recently
from
41e7fa0 to
e1a0f74
Compare
jkotas
reviewed
Oct 1, 2024
am11
force-pushed
the
feature/illumos-port
branch
from
e1a0f74 to
7096c63
Compare
am11
commented
Oct 1, 2024
am11
force-pushed
the
feature/illumos-port
branch
from
ba361e1 to
247d3cb
Compare
janvorli
reviewed
Nov 1, 2024
|
|
||
| if (error != 0) | ||
| PAL_ERROR palError = InternalGetThreadDataFromHandle(pThread, hThread, &pTargetThread, &pobjThread); | ||
| if (palError != NO_ERROR) |
There was a problem hiding this comment.
@am11 I have just discovered that you have reversed this condition by accident. So we effectively never set the name. And if the InternalGetThreadDataFromHandle fails, the code crashes because the pTargetThread is null (I've just investigated such crash and found this to be the culprit)
There was a problem hiding this comment.
Ops, this was an accident. Thanks for catching this. I will make a fix.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligned coreclr, nativeaot, mono and libs.