Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Message property to ExperimentalAttribute #108216

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Add Message property to ExperimentalAttribute #108216

merged 2 commits into from
Nov 26, 2024

Conversation

I-SER-I
Copy link
Contributor

@I-SER-I I-SER-I commented Sep 24, 2024 •
edited
Loading

  • Add Message property
    • Include simple documentation
    • Add set message test

close #107963

@dotnet-issue-labeler dotnet-issue-labeler bot added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Sep 24, 2024
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 24, 2024
This was referenced Sep 24, 2024
Open
Open
Open
@huoyaoyuan huoyaoyuan added area-System.Runtime and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 25, 2024
@tannergooding
Copy link
Member

@jaredpar this is related to the open Roslyn issue: dotnet/roslyn#75221

Does such work need to happen prior to the libraries side being merged, or are we in the clear?

@tannergooding tannergooding merged commit abee177 into dotnet:main Nov 26, 2024
146 checks passed
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
@I-SER-I @tannergooding @mikelle-rogers
feat: Add Message property to ExperimentalAttribute (dotnet#108216)
2e4d44e 
Co-authored-by: Sergey Papikyan <[email protected]>
Co-authored-by: Tanner Gooding <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tannergooding tannergooding tannergooding approved these changes

Assignees
No one assigned
Labels
area-System.Runtime community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add Message property to ExperimentalAttribute
3 participants
@I-SER-I @tannergooding @huoyaoyuan