Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RISC-V] Fixed DBG_DebugBreak stub #107972

Merged
merged 1 commit into from
Sep 18, 2024
Merged

[RISC-V] Fixed DBG_DebugBreak stub #107972

merged 1 commit into from
Sep 18, 2024

Conversation

Bajtazar
Copy link
Contributor

Added missing ret instruction after breakpoint instruction call in the debugbreak.S stub

@shushanhf, I noticed that LA also lacks this instruction, Could you check it?

Part of #84834, cc @dotnet/samsung

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 18, 2024
@risc-vv
Copy link

risc-vv commented Sep 18, 2024 •
edited
Loading

RISC-V Release-CLR-QEMU: 9414 / 9431 (99.82%) 
=======================
      passed: 9414
      failed: 2
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9538
 TOTAL tests: 9538
   REAL time: 46min 11s 520ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

RISC-V Release-FX-QEMU: 575248 / 610961 (94.15%) 
=======================
      passed: 575248
      failed: 339
     skipped: 1581
      killed: 35374
------------------------
  TOTAL libs: 257
 TOTAL tests: 612542
   REAL time: 2h 21min 35s 92ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: 5b49b5841d9ffdbc7f2246eec472615f378cd9c1
CI: 9d2fd18d83dc740f91e7224e77e6665c61d1a038
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/godata/pipelines/Release-CLR-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-CLR-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-CLR-QEMU/testhost.Release/dotnet CORE_ROOT=/godata/pipelines/Release-CLR-QEMU/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 16 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/godata/pipelines/Release-FX-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-FX-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

# TEST_ENV
DOTNET_JitStress=;DOTNET_JitStressRegs=;DOTNET_GCStress=;DOTNET_JITMinOpts=;DOTNET_TailcallStress=;DOTNET_TieredCompilation=
RISC-V Release-CLR-VF2: 9415 / 9431 (99.83%) 
=======================
      passed: 9415
      failed: 1
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9538
 TOTAL tests: 9538
   REAL time: 3h 8min 4s 565ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

RISC-V Release-FX-VF2: 493778 / 551332 (89.56%) 
=======================
      passed: 493778
      failed: 20
     skipped: 1465
      killed: 57534
------------------------
  TOTAL libs: 257
 TOTAL tests: 552797
   REAL time: 2h 29min 17s 604ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: 5b49b5841d9ffdbc7f2246eec472615f378cd9c1
CI: 9d2fd18d83dc740f91e7224e77e6665c61d1a038
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/var/lib/go-agent/pipelines/Release-CLR-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-CLR-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-CLR-VF2/testhost.Release/dotnet CORE_ROOT=/var/lib/go-agent/pipelines/Release-CLR-VF2/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 8 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/var/lib/go-agent/pipelines/Release-FX-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-FX-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

# TEST_ENV
DOTNET_JitStress=;DOTNET_JitStressRegs=;DOTNET_GCStress=;DOTNET_JITMinOpts=;DOTNET_TailcallStress=;DOTNET_TieredCompilation=

@am11 am11 added the arch-riscv Related to the RISC-V architecture label Sep 18, 2024
@shushanhf
Copy link
Contributor

Thanks very much.
I will update it for LoongArch64.

@shushanhf shushanhf mentioned this pull request Sep 18, 2024
Merged
bartlomiejko
bartlomiejko approved these changes Sep 18, 2024
View reviewed changes
Copy link

@bartlomiejko bartlomiejko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@build-analysis build-analysis bot mentioned this pull request Sep 18, 2024
Open
3 tasks
SzpejnaDawid
SzpejnaDawid approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@SzpejnaDawid SzpejnaDawid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkotas jkotas merged commit 69851f2 into dotnet:main Sep 18, 2024
88 of 90 checks passed
sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
@Bajtazar @sirntar
[RISC-V] Fixed bug in debug stub (dotnet#107972)
a85d525
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SzpejnaDawid SzpejnaDawid SzpejnaDawid approved these changes

@bartlomiejko bartlomiejko bartlomiejko approved these changes

@gbalykov gbalykov gbalykov approved these changes

@viewizard viewizard viewizard approved these changes

@yurai007 yurai007 yurai007 approved these changes

@jkotas jkotas jkotas approved these changes

@tomeksowi tomeksowi tomeksowi approved these changes

Assignees

@Bajtazar Bajtazar

Labels
arch-riscv Related to the RISC-V architecture area-PAL-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.