Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: disable scev analysis for non-integral types #107618

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

AndyAyersMS
Copy link
Member

We could conceivably handle some cases of double and vector evolution, or perhaps invariant subtrees of these types in integral scevs, but we're not set up to do this today.

Fixes #107543.

We could conceivably handle some cases of double and vector evolution, or perhaps
invariant subtrees of these types in integral scevs, but we're not set up to do this today.

Fixes dotnet#107543.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 10, 2024
@AndyAyersMS
Copy link
Member Author

@EgorBo PTAL
cc @dotnet/jit-contrib

No diffs in SPMI.

@AndyAyersMS AndyAyersMS requested a review from EgorBo September 10, 2024 15:22
Copy link
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM giving zero diffs

@AndyAyersMS
Copy link
Member Author

No diffs from CI...

I am not planning to backport this. Not sure it causes any actual problems.

@AndyAyersMS AndyAyersMS merged commit 636c863 into dotnet:main Sep 10, 2024
114 checks passed
jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Sep 17, 2024
We could conceivably handle some cases of double and vector evolution, or perhaps
invariant subtrees of these types in integral scevs, but we're not set up to do this today.

Fixes dotnet#107543.
sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
We could conceivably handle some cases of double and vector evolution, or perhaps
invariant subtrees of these types in integral scevs, but we're not set up to do this today.

Fixes dotnet#107543.
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
2 participants