Add NativeRuntimeEventSource metadata to NativeAot CoreLib #106641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to allow consumers to parse the payload. Delete unnecessary runtimeflavor argument of genRuntimeEventSources.py script. Fixes dotnet#105556
This was referenced Aug 19, 2024
jkotas
commented
Aug 19, 2024
| # Get the list of event nodes. | ||
| eventNodes = eventsNode.getElementsByTagName("event") | ||
|
|
||
| # Build the list of used keywords |
There was a problem hiding this comment.
This will omit OverrideAndSuppressNGenEvents, StartEnumerationKeyword and EndEnumerationKeyword keywords in CoreCLR version as well since they are unused. I assume that it is fine to omit unused keywords from metadata.
There was a problem hiding this comment.
It should be fine to omit, we just need the metadata to parse events so if they are never emitted than we don't need them
jkotas
commented
Aug 19, 2024
| @@ -297,11 +297,6 @@ | |||
| <ProjectReference Include="$(LibrariesProjectRoot)\System.Private.CoreLib\gen\System.Private.CoreLib.Generators.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
There was a problem hiding this comment.
We do not have any .tt files in CoreLib anymore
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Aug 19, 2024
davmason
approved these changes
Aug 20, 2024
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10475918830 |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to allow consumers to parse the payload.
Delete unnecessary runtimeflavor argument of genRuntimeEventSources.py script.
Fixes #105556