Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inter branch merge flow config for 9.0 RC branches #106425

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

carlossanlop
Copy link
Member

No description provided.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

github-merge-flow.jsonc Outdated Show resolved Hide resolved
github-merge-flow.jsonc Outdated Show resolved Hide resolved
@carlossanlop
Copy link
Member Author

No CI validation for this change. Will merge right away to get this included in the 9.0 branch.

@carlossanlop
Copy link
Member Author

carlossanlop commented Aug 15, 2024

This isn't working. We have had some new commits in the release/9.0-rc1 branch but I don't see any PRs created to autoflow those commits to the released/9.0 branch. What am I missing, @jkoritzinsky @mmitche @hoyosjs @f-alizada?

@carlossanlop
Copy link
Member Author

Yeah, it's not running: https://github.com/dotnet/runtime/actions/workflows/inter-branch-merge-flow.yml

What I suspect is that it won't work unless it's in both release/9.0-rc1 and release/9.0.

I was hoping it would get autotriggered by just existing in release/9.0-rc1. I'll backport it to the remaining branch and see if that does it.

@carlossanlop
Copy link
Member Author

carlossanlop commented Aug 16, 2024

Actually, I snapped both release/9.0 and release/9.0-rc1 after merging this PR, meaning all the necessary branches already include this.

@f-alizada
Copy link
Contributor

@carlossanlop I have created the PR #106614 which adds the workflow file to the branch.
This is the reason it is not triggering on merges into the branches.
Adding the workflow to the main here: #106616 as well to avoid such situations in future.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants