Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM-SVE: Add LD/ST info to SVE instructions #105512 #106328

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

a74nh
Copy link
Contributor

@a74nh a74nh commented Aug 13, 2024

Fixes #105512

Added LD, ST and CMP flags to all the relevant SVE instructions.

(I don't think CMP is checked anywhere, but did it anyway).

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 13, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 13, 2024
@a74nh a74nh marked this pull request as ready for review August 13, 2024 14:28
@a74nh a74nh changed the title ARM-SVE: Add LD/ST info to SVE instructions ARM-SVE: Add LD/ST info to SVE instructions #105512 Aug 13, 2024
@a74nh
Copy link
Contributor Author

a74nh commented Aug 13, 2024

@dotnet/arm64-contrib @kunalspathak

@a74nh a74nh added the arm-sve Work related to arm64 SVE/SVE2 support label Aug 13, 2024
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume all sve stress tests passes.

@a74nh
Copy link
Contributor Author

a74nh commented Aug 13, 2024

I assume all sve stress tests passes.

Yes, they all work.

It takes 50mins to run all the stress tests for RO on my machine. Thankfully I don't think it will be added to the CI like that.

@JulieLeeMSFT JulieLeeMSFT added this to the 9.0.0 milestone Aug 14, 2024
@JulieLeeMSFT JulieLeeMSFT merged commit ab260b8 into dotnet:main Aug 14, 2024
106 of 111 checks passed
@a74nh a74nh deleted the ldstinfo_github branch August 14, 2024 12:31
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arm64/Sve: Ld/St info should be added for SVE instructions
3 participants