[cdac] Implement ISOSDacInterface::GetObjectData getting COM RCW/CCW #105846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 2, 2024
25 tasks
AaronRobinsonMSFT
approved these changes
Aug 2, 2024
| struct cdac_data<InteropSyncBlockInfo> | ||
| { | ||
| #ifdef FEATURE_COMINTEROP | ||
| static constexpr size_t CCW = offsetof(InteropSyncBlockInfo, m_pCCW); |
There was a problem hiding this comment.
I assume this is only for built-in. Are we going to defer ComWrappers support for later? Same for RCW.
There was a problem hiding this comment.
Yeah. I deferred for later.
I went back and forth on object contract should have
GetComDatafor built-in andGetComWrappersDatafor ComWrappersGetComDatafor both built-in and ComWrappers- Separate functions for each (trying to thing of names was a struggle) - GetRCW/CCW (built-in), GetComWrappersRCW, GetComWrappersManagedObjectWrapperList
I ended up with (1) - definitely open to thoughts.
There was a problem hiding this comment.
What about if we call it "BuiltInComData" to match how our docs and current code talk about built-in COM vs ComWrappers?
Then in the future, the contract to pull data about built-in RCWs and CCWs could be called "BuiltInCom" and the ComWrappers one could be "ComWrappers".
There was a problem hiding this comment.
Renamed to GetBuiltInComData
elinor-fung
commented
Aug 2, 2024
Co-authored-by: Aaron Robinson <[email protected]>
This was referenced Aug 2, 2024
AaronRobinsonMSFT
approved these changes
Aug 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SyncTableEntry,SyncBlock,InteropSyncBlockInfodata descriptors,SyncTableEntriesglobalObjectcontractGetComDatatoObjectcontractISOSDacInterface::GetObjectDatasuch that it populates the RCW/CCWContributes to #99302
Manually validated with a COM server and callback that the RCW/CCW were set when expected and matched values returned by DAC.
Ran SOS unit tests from diagnostics repo using private build.