Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests for GatherVectorByteOffsets (#105568) #105747

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Fix failing tests for GatherVectorByteOffsets (#105568) #105747

merged 3 commits into from
Aug 1, 2024

Conversation

SwapnilGaikwad
Copy link
Contributor

Fixes: #105568

@a74nh @kunalspathak @dotnet/arm64-contrib @arch-arm64-sve

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 31, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 31, 2024
@build-analysis build-analysis bot mentioned this pull request Jul 31, 2024
Closed
@SwapnilGaikwad SwapnilGaikwad marked this pull request as ready for review July 31, 2024 14:04
amanasifkhalid
amanasifkhalid approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@amanasifkhalid amanasifkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if stress tests pass, thanks!

src/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.cs Outdated Show resolved Hide resolved
@JulieLeeMSFT JulieLeeMSFT added this to the 9.0.0 milestone Jul 31, 2024
@SwapnilGaikwad
Copy link
Contributor Author

LGTM if stress tests pass, thanks!

Stress tests are passing now 
===================Running default===================
------------------- {} -------------------
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorWithByteOffsets_float_int() : 15
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorWithByteOffsets_int_int() : 15
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorWithByteOffsets_uint_int() : 15
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorWithByteOffsets_float_uint() : 15
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorWithByteOffsets_int_uint() : 15
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorWithByteOffsets_uint_uint() : 15
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorWithByteOffsets_double_long() : 15
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorWithByteOffsets_long_long() : 15
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorWithByteOffsets_ulong_long() : 15
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorWithByteOffsets_double_ulong() : 15
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorWithByteOffsets_long_ulong() : 15
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorWithByteOffsets_ulong_ulong() : 15
===================Running jitstress===================
------------------- {'JitMinOpts': '1'} -------------------
------------------- {'JitStress': '1'} -------------------
------------------- {'JitStress': '2'} -------------------
------------------- {'JitStress': '1', 'TieredCompilation': '1'} -------------------
------------------- {'JitStress': '2', 'TieredCompilation': '1'} -------------------
------------------- {'TailcallStress': '1'} -------------------
------------------- {'ReadyToRun': '0'} -------------------
===================Running jitstressregs===================
------------------- {'JitStressRegs': '1'} -------------------
------------------- {'JitStressRegs': '2'} -------------------
------------------- {'JitStressRegs': '3'} -------------------
------------------- {'JitStressRegs': '4'} -------------------
------------------- {'JitStressRegs': '8'} -------------------
------------------- {'JitStressRegs': '0x10'} -------------------
------------------- {'JitStressRegs': '0x80'} -------------------
------------------- {'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStressRegs': '0x2000'} -------------------
===================Running jitstress2-jitstressregs===================
------------------- {'JitStress': '2', 'JitStressRegs': '1'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '2'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '3'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '4'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '8'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x10'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x80'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x2000'} -------------------

This was referenced Aug 1, 2024
Open
Open
@amanasifkhalid amanasifkhalid merged commit 71d8ae6 into dotnet:main Aug 1, 2024
70 checks passed
@SwapnilGaikwad SwapnilGaikwad deleted the github-fix-GatherVectorWithByteOffsets-tests branch August 2, 2024 09:14
@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amanasifkhalid amanasifkhalid amanasifkhalid approved these changes

Assignees

@SwapnilGaikwad SwapnilGaikwad

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

Arm64/Sve: GatherVectorWithByteOffsets fails for JitStressRegs
3 participants
@SwapnilGaikwad @amanasifkhalid @JulieLeeMSFT