Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Don't run fgUpdateFlowGraph after reordering blocks if using RPO-based layout #105652

Closed
wants to merge 4 commits into from
Closed

JIT: Don't run fgUpdateFlowGraph after reordering blocks if using RPO-based layout #105652

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bab4a94
Avoid running flow opts after layout
amanasifkhalid Jul 29, 2024
515fc1b
Comment
amanasifkhalid Jul 29, 2024
f2cceb5
Merge branch 'main' into update-flowgraph-post-layout
amanasifkhalid Jul 30, 2024
225025d
Merge branch 'main' into update-flowgraph-post-layout
amanasifkhalid Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/coreclr/jit/optimizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2449,7 +2449,14 @@ PhaseStatus Compiler::optOptimizeLayout()

fgUpdateFlowGraph(/* doTailDuplication */ false);
fgReorderBlocks(/* useProfile */ true);
fgUpdateFlowGraph(/* doTailDuplication */ false, /* isPhase */ false);

// The RPO-based layout does not introduce new blocks,
// so we don't need to run fgUpdateFlowGraph again.
//
if (!JitConfig.JitDoReversePostOrderLayout())
{
fgUpdateFlowGraph(/* doTailDuplication */ false, /* isPhase */ false);
}

// fgReorderBlocks can cause IR changes even if it does not modify
// the flow graph. It calls gtPrepareCost which can cause operand swapping.
Expand Down
Loading