-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix codespaces build by bumping clang llvm #105385
Fix codespaces build by bumping clang llvm #105385
Conversation
Tagging subscribers to 'arch-wasm': @lewing |
We should think about updating the documentation on how to build dotnet/runtime on linux at some point too. The current requirements just say to install clang, but it will be more complex now. https://github.com/dotnet/runtime/blob/main/docs/workflow/requirements/linux-requirements.md I don't think that needs to happen in this PR necessarily though. |
Note that the clang-16 requirement only applies to builds where we use our llvm, i.e. wasm and mobile. On Desktop platforms an earlier clang should be fine still. |
You mean that the doc is misleading now? Running codespaces with newer clang than 14 for desktop won't do any harm I think. We don't have a better, wasm-only document. Do you think we should update
to
? |
Yeah I was mostly concerned about the docs |
Command e.g.
./build.sh mono+libs -c release -os browser
Without this change:
With this change:
build succeeds.
Both are tested with applying the fix from #105110.
Ubuntu 22.04 does not have system clang/llvm newer than 14.0, so we have to manually add repo and update packages from it. I took v=18 because that's what we have on CI.