Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARM64-SVE: Add GatherVectorWithByteOffsetFirstFaulting #105369

Closed
wants to merge 30 commits into from
Closed

ARM64-SVE: Add GatherVectorWithByteOffsetFirstFaulting #105369

wants to merge 30 commits into from

Conversation

amanasifkhalid
Copy link
Member

Part of #99957, dependent on #104502. Stress tests are passing.

cc @dotnet/arm64-contrib.

TIHan and others added 30 commits July 2, 2024 12:54
@TIHan
Initial work
d0efc9e
@TIHan
Merge remote-tracking branch 'upstream/main' into sve-ffr-part1
42148fd
@TIHan
FirstFaulting partially works
a7773ac
@TIHan
Added template
76b42bd
@TIHan
Trying to test first-faulting behavior
bb01e37
@TIHan
Using BoundedMemory to test FirstFaulting behavior for LoadVector.
a602b24
@TIHan
Fix size in validation
60d410a
@TIHan
Added more helper functions. Added conditional select tests for LoadV…
aee87d7 
…ectorFirstFaulting.
@TIHan
Added first-faulting behavior tests for GatherVectorFirstFaulting
7f3bb3c
@TIHan
Merging with main
d952ff1
@TIHan
Added GetFfr suffix-style APIs
3923946
@TIHan
Fixing GatherVector tests
461b6a3
@TIHan
Formatting
d5b8675
@TIHan
Feedback
07833e3
@TIHan
Merge remote-tracking branch 'upstream/main' into sve-ffr-part1
ce5a9bd
@TIHan
Feedback
05fb46d
@tannergooding
Ensure the P/Invokes are blittable
c63f878
@TIHan
Merging
a4533fe
@TIHan
Merge remote-tracking branch 'upstream/main' into sve-ffr-part1
72d1dea
@TIHan
Fix build
6c28927
@TIHan
Remove checking for zeroes after the fault
fb2012e
@TIHan
Added GatherVectorFirstFaultingVectorBases test template, but current…
aca6759 
…ly without the FirstFaulting test. Added SveFfrTest template.
@TIHan
Mark GetFfr methods as side-effectful
d781fdc
@TIHan
Verifying expected fault result. Test weaks.
a73fe35
@TIHan
Merging with main
81882a4
@TIHan
Fix build
ad5ec2e
@amanasifkhalid
Add GatherVectorWithByteOffsetFirstFaulting
a8919e3
@amanasifkhalid
Fix tests
7fc3b21
@amanasifkhalid
Remove log
7ac2787
@amanasifkhalid
Fix validation
aa8b720
@amanasifkhalid amanasifkhalid added the arm-sve Work related to arm64 SVE/SVE2 support label Jul 23, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI new-api-needs-documentation labels Jul 23, 2024
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@amanasifkhalid amanasifkhalid mentioned this pull request Jul 23, 2024
Closed
This was referenced Jul 24, 2024
Closed
Open
Closed
@amanasifkhalid amanasifkhalid mentioned this pull request Jul 26, 2024
Closed
@amanasifkhalid
Copy link
Member Author

Retiring in favor of #106199.

@amanasifkhalid amanasifkhalid deleted the sve-gather branch August 9, 2024 17:04
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@amanasifkhalid amanasifkhalid

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amanasifkhalid @TIHan @tannergooding