Replace the bespoke OrderedDictionary with a backport of System.Collections.Generic.OrderedDictionary #105016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions.Generic.OrderedDictionary.
eiriktsarpalis
commented
Jul 17, 2024
| @@ -6,6 +6,7 @@ | |||
| <IsPartialFacadeAssembly>true</IsPartialFacadeAssembly> | |||
| <ContractTypesPartiallyMoved>true</ContractTypesPartiallyMoved> | |||
| <UseCompilerGeneratedDocXmlFile>false</UseCompilerGeneratedDocXmlFile> | |||
| <DefineConstants>SYSTEM_COLLECTIONS;$(DefineConstants)</DefineConstants> | |||
There was a problem hiding this comment.
Constant follows naming convention of SYSTEM_PRIVATE_CORELIB
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
This was referenced Jul 17, 2024
stephentoub
reviewed
Jul 18, 2024
src/libraries/Common/src/System/Collections/Generic/EnumerableHelpers.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jul 18, 2024
stephentoub
approved these changes
Jul 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the introduction of System.Collection.Generic.OrderedDictionary in .NET 9,
JsonObjecthas been using two separate implementations of ordered dictionary: the built-in collection fornet9.0and a bespoke implementation for older targets. This PR removes the bespoke implementation and backports the new collection type to the older targets.