Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new JsonIgnoreAttribute WhenWriting/WhenReading #104562

Merged
merged 7 commits into from
Nov 1, 2024
Merged

add new JsonIgnoreAttribute WhenWriting/WhenReading #104562

merged 7 commits into from
Nov 1, 2024

Conversation

WeihanLi
Copy link
Contributor

@WeihanLi WeihanLi commented Jul 8, 2024 •
edited
Loading

feat: add new JsonIgnoreAttribute WhenWriting/WhenReading

fixes #66490

  • test cases

@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 8, 2024
This was referenced Jul 8, 2024
Closed
Open
This was referenced Jul 22, 2024
Open
Open
Closed
Closed
Open
Closed
Open
Closed
Open
This was referenced Jul 31, 2024
Open
Closed
Closed
@WeihanLi WeihanLi marked this pull request as ready for review July 31, 2024 23:00
This was referenced Aug 1, 2024
Open
Open
Closed
@eiriktsarpalis
Copy link
Member

@WeihanLi thanks for submitting the PR, however since we're currently in the process of finishing up .NET 9 we are no longer merging PRs adding new features. We can revisit this in a couple weeks' time once the .NET 9 branch has been snapped from main.

@eiriktsarpalis eiriktsarpalis added this to the 10.0.0 milestone Aug 2, 2024
@eiriktsarpalis eiriktsarpalis added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 2, 2024
@eiriktsarpalis eiriktsarpalis removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 11, 2024
@eiriktsarpalis
Copy link
Member

Apologies for the delay getting back to you, we can continue work on this PR for .NET 10 now.

This was referenced Oct 9, 2024
Open
Open
eiriktsarpalis
eiriktsarpalis approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@build-analysis build-analysis bot mentioned this pull request Oct 31, 2024
Open
@eiriktsarpalis eiriktsarpalis merged commit 357b09d into dotnet:main Nov 1, 2024
83 checks passed
@WeihanLi WeihanLi deleted the extended-json-ignore-condition branch November 1, 2024 12:18
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

@stephentoub stephentoub Awaiting requested review from stephentoub

Assignees
No one assigned
Labels
area-System.Text.Json community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Extend JsonIgnoreCondition
3 participants
@WeihanLi @eiriktsarpalis @stephentoub