Fix PHI non-null pattern #104493
Closed
Fix PHI non-null pattern #104493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
3 tasks
This was referenced Jul 11, 2024
Open
|
PTAL @AndyAyersMS @jakobbotsch cc @dotnet/jit-contrib Diffs I tried to fix the TP hit by only inspecting root node for PHI, but there is still 0.1% regression. Can we accept it? |
jakobbotsch
reviewed
Jul 12, 2024
| @@ -1149,16 +1149,14 @@ AssertionIndex Compiler::optCreateAssertion(GenTree* op1, | |||
| } | |||
| } | |||
|
|
|||
| if (fgIsBigOffset(offset) || op1->gtOper != GT_LCL_VAR) | |||
| if (fgIsBigOffset(offset) || !op1->IsLocal()) | |||
There was a problem hiding this comment.
Is this change ok? LCL_FLD will create an assertion about the parent local without encoding any information about the offset, which seems odd.
jakobbotsch
reviewed
Jul 12, 2024
Comment on lines
-11139
to
-11144
| else if (value->TypeGet() == TYP_REF) | ||
| { | ||
| // If we have an unsafe IL store of a TYP_REF to a non-ref (typically a TYP_BYREF) | ||
| // then don't propagate this ValueNumber to the lhs, instead create a new unique VN. | ||
| valueVNPair.SetBoth(vnStore->VNForExpr(compCurBB, store->TypeGet())); | ||
| } |
There was a problem hiding this comment.
Might be a good idea to see if you can dig up why this was added to verify it won't cause any problems to remove it.
|
superseded by #108420 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #104489
Thanks to @AndyAyersMS and @jakobbotsch for ideas how to fix it.
Let's see what CI thinks..