Fix missing hashcode set in OrderedDictionary.SetAt #103643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...raries/System.Collections/tests/Generic/OrderedDictionary/OrderedDictionary.Generic.Tests.cs
Show resolved
Hide resolved
|
CI appears to be in a bad state |
|
/ba-g ci is horked and this bug is blocking another p6 pr |
danmoseley
reviewed
Jun 18, 2024
| @@ -809,8 +809,8 @@ public void SetAt(int index, TKey key, TValue value) | |||
| } | |||
|
|
|||
| // The key doesn't match that index. If it exists elsewhere in the collection, fail. | |||
| uint _ = 0, collisionCount = 0; | |||
| if (IndexOf(key, ref _, ref collisionCount) >= 0) | |||
| uint hashCode = 0, collisionCount = 0; | |||
There was a problem hiding this comment.
Just curious why do we use uint for collision count? In general we use signed everywhere unless we need the full range.
There was a problem hiding this comment.
This just copies what Dictionary<TKey, TValue> does. I believe it uses uint just to make it very clear there's no possibility of overflow.
This was referenced Jun 19, 2024
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103637