Support environment variables with empty value #103551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoeplinger
reviewed
Jun 17, 2024
...m.Runtime/tests/System.Runtime.Extensions.Tests/System/Environment.SetEnvironmentVariable.cs
Show resolved
Hide resolved
|
Also fixes #34446 I assume? |
It does now - worth fixing for consistency. |
jkotas
commented
Jun 17, 2024
src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Unix.cs
Show resolved
Hide resolved
jkotas
added
the
breaking-change
dotnet-policy-service
bot
added
the
needs-breaking-change-doc-created
3 tasks
stephentoub
approved these changes
Jun 18, 2024
jkotas
changed the title
|
Breaking change issue created: dotnet/docs#41471 |
|
/ba-g Known issue #103642 that has been fixed and closed already |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment.SetEnvironmentAPI did not make distinction between null and empty string value. It treated both as request to delete the environment variable. It made it impossible to create an environment variable with empty string value. This change updatesEnvironment.SetEnvironmentto treat empty string value as empty string value (null value is still treated as request to delete the environment variable).Also, this change updates ProcessStartInfo.Environment to treat null vs. empty string the same way as
Environment.SetEnvironmentfor consistency.Fixes #50554
Fixes #34446