Set UseNativeAotForComponents to false on bionic #103454
Conversation
This was enabled in #103273 but needs more work to actually build. Official builds are failing.
| @@ -18,6 +18,9 @@ | |||
| <SysRoot Condition="'$(CrossBuild)' == 'true' and '$(HostOS)' != 'windows'">$(ROOTFS_DIR)</SysRoot> | |||
| <LinkerFlavor Condition="'$(CrossBuild)' == 'true' and '$(TargetsLinux)' == 'true'">lld</LinkerFlavor> | |||
| <CustomLinkerArgToolchainArg Condition="'$(CrossBuild)' == 'true' and '$(HostArchitecture)' == '$(TargetArchitecture)' and '$(HostOS)' != 'windows'">--gcc-toolchain=$(ROOTFS_DIR)/usr</CustomLinkerArgToolchainArg> | |||
|
|
|||
| <!-- disable on linux-bionic, for now --> | |||
| <UseNativeAotForComponents Condition="'$(TargetsLinuxBionic)' == 'true'">false</UseNativeAotForComponents> | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
It's a local workaround for a problem in this project file, as opposed to global statement.
Publishing for bionic is supposed to be supported for components but this project needs to configure it, like it's doing in the lines above for other crossbuilds (at minimum, set PublishAotUsingRuntimePack). I could have tried to fix it but official builds are failing and it was blocked before #103273 so I don't feel bad just blocking it "for now".
I'll move it so it doesn't conflict with #103375 but it will be in the wrong spot now given the state of main and I haven't made my mind if it will be in wrong spot after that PR still (the workaround is too detached from where the problem is).
dotnet-policy-service
bot
added
the
linkable-framework
…)" This reverts commit d901213.
* Revert "Do not set UseNativeAotForComponents for arm32 MUSL (#103469)" This reverts commit f1f0750. * Revert "Set UseNativeAotForComponents to false on bionic (#103454)" This reverts commit d901213. * Revert "Try fixing x86 Windows legs (#103411)" This reverts commit 6927fea. * Revert "Consolidate <NativeAotSupported definitions (#103273)" This reverts commit b86c463.
This was enabled in #103273 but needs more work to actually build. Official builds are failing.