update parsing for manually configured proxy on Windows #103328
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38670
Fixes #91045
The current behavior was intruded by dotnet/corefx#40082 to support multiple proxies.
The logic for parsing PAC files was also applied to the manual proxy setting.
But as the issues above noticed that does not quite reflect reality.
The existing code assumes that ion the proxy location starts with
http://
it would apply only to HTTP (and not HTTPS traffic. In reality one can puthttp://x.y.x/
string to the proxy location and all browsers would apply it to both http & https.If the string is prefixed with
http=
it is also respected e.g.http=http://x.y.x/
would apply only for HTTP and not HTTPS traffic.To limit regressions I split the logic and tests and I left PAC processing ASIS and I made small change to relax the restrictions if it comes from the manual settings location.