-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Regex.EnumerateSplits #103307
Add Regex.EnumerateSplits #103307
Conversation
Note regarding the
|
Note regarding the
|
...s/System.Text.RegularExpressions/src/System/Text/RegularExpressions/Regex.EnumerateSplits.cs
Outdated
Show resolved
Hide resolved
...s/System.Text.RegularExpressions/src/System/Text/RegularExpressions/Regex.EnumerateSplits.cs
Show resolved
Hide resolved
...s/System.Text.RegularExpressions/src/System/Text/RegularExpressions/Regex.EnumerateSplits.cs
Show resolved
Hide resolved
...ibraries/System.Text.RegularExpressions/tests/FunctionalTests/Regex.EnumerateSplits.Tests.cs
Show resolved
Hide resolved
src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/Regex.Split.Tests.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of questions but looks great. Thanks Steve!
...s/System.Text.RegularExpressions/src/System/Text/RegularExpressions/Regex.EnumerateSplits.cs
Show resolved
Hide resolved
...ibraries/System.Text.RegularExpressions/tests/FunctionalTests/Regex.EnumerateSplits.Tests.cs
Show resolved
Hide resolved
I know this is already merged, but shouldn't |
If we were starting from scratch, yes, but this is how all the other regex methods spell it, e.g. https://learn.microsoft.com/en-us/dotnet/api/system.text.regularexpressions.regex.match?view=net-8.0#system-text-regularexpressions-regex-match(system-string-system-int32), so we're staying consistent with that. |
Closes #100369