[workloads] Add net current to current names to make them match in net10

[lewing]

No description provided.

[joeloff]

Does the alias need the {NetVersion} too?

[lewing]

probably need to make sure we add aliases where there weren't before and I need to make sure I understand what is going on with the win runtime packs

[marcpopMSFT]

I don't think we had the netversion in any aliases before, it was just the pack names themselves (as this was for VS authoring)

[steveisok]

This looks good, but we should run an official build as well to really check.

[marcpopMSFT]

@lewing This only adds the net9 labels. Will there be a process to port the PR you have for net8 to add those same labels into main (as that PR won't port without fixing conflicts)?

[lewing]

@lewing This only adds the net9 labels. Will there be a process to port the PR you have for net8 to add those same labels into main (as that PR won't port without fixing conflicts)?

We discussed this offline but I'll follow up here too incase others have the same question. The net8 labels are already changed in main, the issue is that before this pr the names for the release branches wouldn't have the embedded change

[MichalStrehovsky]

@lewing I don't think I've seen a successful official build since this merged. First there were all sorts of things wrong with it, but these days it stabilized to:

D:\a\_work\1\s\src\workloads\workloads.csproj(147,5): error : System.Collections.Generic.KeyNotFoundException: The given key 'Microsoft.NET.Runtime.LibraryBuilder.Sdk' was not present in the dictionary.
D:\a\_work\1\s\src\workloads\workloads.csproj(147,5): error :    at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
D:\a\_work\1\s\src\workloads\workloads.csproj(147,5): error :    at Microsoft.DotNet.Build.Tasks.Workloads.CreateVisualStudioWorkload.ExecuteCore() in /_/src/Microsoft.DotNet.Build.Tasks.Workloads/src/CreateVisualStudioWorkload.wix.cs:line 221
D:\a\_work\1\s\src\workloads\workloads.csproj(147,5): error :    at Microsoft.DotNet.Build.Tasks.Workloads.VisualStudioWorkloadTaskBase.Execute() in /_/src/Microsoft.DotNet.Build.Tasks.Workloads/src/VisualStudioWorkloadTaskBase.wix.cs:line 105
##[error]src\workloads\workloads.csproj(147,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) System.Collections.Generic.KeyNotFoundException: The given key 'Microsoft.NET.Runtime.LibraryBuilder.Sdk' was not present in the dictionary.
   at System.Collections.Generic.Dictionary`2.get_Item(TKey key)

I'm not sure if this PR is to blame because there were so many other issues around the time it merged, but it looks likely.

[lewing]

@lewing I don't think I've seen a successful official build since this merged. First there were all sorts of things wrong with it, but these days it stabilized to:

D:\a\_work\1\s\src\workloads\workloads.csproj(147,5): error : System.Collections.Generic.KeyNotFoundException: The given key 'Microsoft.NET.Runtime.LibraryBuilder.Sdk' was not present in the dictionary.
D:\a\_work\1\s\src\workloads\workloads.csproj(147,5): error :    at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
D:\a\_work\1\s\src\workloads\workloads.csproj(147,5): error :    at Microsoft.DotNet.Build.Tasks.Workloads.CreateVisualStudioWorkload.ExecuteCore() in /_/src/Microsoft.DotNet.Build.Tasks.Workloads/src/CreateVisualStudioWorkload.wix.cs:line 221
D:\a\_work\1\s\src\workloads\workloads.csproj(147,5): error :    at Microsoft.DotNet.Build.Tasks.Workloads.VisualStudioWorkloadTaskBase.Execute() in /_/src/Microsoft.DotNet.Build.Tasks.Workloads/src/VisualStudioWorkloadTaskBase.wix.cs:line 105
##[error]src\workloads\workloads.csproj(147,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) System.Collections.Generic.KeyNotFoundException: The given key 'Microsoft.NET.Runtime.LibraryBuilder.Sdk' was not present in the dictionary.
   at System.Collections.Generic.Dictionary`2.get_Item(TKey key)

I'm not sure if this PR is to blame because there were so many other issues around the time it merged, but it looks likely.

That error was fixed a while back, what build are you looking at?

[MichalStrehovsky]

@lewing I don't think I've seen a successful official build since this merged. First there were all sorts of things wrong with it, but these days it stabilized to:

D:\a\_work\1\s\src\workloads\workloads.csproj(147,5): error : System.Collections.Generic.KeyNotFoundException: The given key 'Microsoft.NET.Runtime.LibraryBuilder.Sdk' was not present in the dictionary.
D:\a\_work\1\s\src\workloads\workloads.csproj(147,5): error :    at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
D:\a\_work\1\s\src\workloads\workloads.csproj(147,5): error :    at Microsoft.DotNet.Build.Tasks.Workloads.CreateVisualStudioWorkload.ExecuteCore() in /_/src/Microsoft.DotNet.Build.Tasks.Workloads/src/CreateVisualStudioWorkload.wix.cs:line 221
D:\a\_work\1\s\src\workloads\workloads.csproj(147,5): error :    at Microsoft.DotNet.Build.Tasks.Workloads.VisualStudioWorkloadTaskBase.Execute() in /_/src/Microsoft.DotNet.Build.Tasks.Workloads/src/VisualStudioWorkloadTaskBase.wix.cs:line 105
##[error]src\workloads\workloads.csproj(147,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) System.Collections.Generic.KeyNotFoundException: The given key 'Microsoft.NET.Runtime.LibraryBuilder.Sdk' was not present in the dictionary.
   at System.Collections.Generic.Dictionary`2.get_Item(TKey key)

I'm not sure if this PR is to blame because there were so many other issues around the time it merged, but it looks likely.

That error was fixed a while back, what build are you looking at?

Sorry, I've lost it. We have brand new official build issues now but official build hasn't really worked in a week so I'm just trying to figure out what are all the things that need to be fixed in parallel. Looks like this one shouldn't be an issue anymore then.

[lewing]

I'm not sure if this PR is to blame because there were so many other issues around the time it merged, but it looks likely.

That error was fixed a while back, what build are you looking at?

Sorry, I've lost it. We have brand new official build issues now but official build hasn't really worked in a week so I'm just trying to figure out what are all the things that need to be fixed in parallel. Looks like this one shouldn't be an issue anymore then.

There are a lot of people trying to get the official build passing again, hitting a lot of infrastructure problems at the moment.