Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose additional metadata on the STJ contract model. #102902

Merged
merged 6 commits into from
May 31, 2024
Merged

Expose additional metadata on the STJ contract model. #102902

merged 6 commits into from
May 31, 2024

Conversation

eiriktsarpalis
Copy link
Member

Fix #102078. Fix #77306.

Contributes to #100159

@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@eiriktsarpalis eiriktsarpalis self-assigned this May 30, 2024
@eiriktsarpalis eiriktsarpalis added this to the 9.0.0 milestone May 30, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis bot mentioned this pull request May 31, 2024
Closed
This was referenced May 31, 2024
Open
Open
@eiriktsarpalis eiriktsarpalis merged commit bde5a52 into dotnet:main May 31, 2024
83 checks passed
@eiriktsarpalis eiriktsarpalis deleted the stj-additional-metadata branch May 31, 2024 17:42
@eiriktsarpalis eiriktsarpalis mentioned this pull request Jun 6, 2024
Merged
@eerhardt eerhardt mentioned this pull request Jun 10, 2024
Closed
@github-actions github-actions bot mentioned this pull request Jun 11, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@jozkee jozkee Awaiting requested review from jozkee

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-System.Text.Json new-api-needs-documentation
Projects
None yet
Milestone
9.0.0
2 participants
@eiriktsarpalis @stephentoub