-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][wasi] Allow to build wasi in library mode #102806
Conversation
Doesn't it fix #89577 as well? |
No, these changes are for |
src/mono/nuget/Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk/Sdk/Sdk.props
Outdated
Show resolved
Hide resolved
Is this waiting for other changes or ready to go? |
@lewing It is ready to go unless there are further changes needed based on the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Failures are not related to PR changes. |
By this PR we are supporting library mode for wasi.
Here are all possibilites to build wasi.
Fixes #96869