Allow non-IMemberDefinition sources to be origin for event methods #102613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-Tools-ILLink
dotnet-policy-service
bot
added
the
linkable-framework
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas |
sbomer
approved these changes
May 23, 2024
Co-authored-by: Sven Boemer <[email protected]>
vitek-karas
approved these changes
May 23, 2024
jtschuster
added a commit
to jtschuster/runtime
that referenced
this pull request
May 28, 2024
agocke
pushed a commit
that referenced
this pull request
May 29, 2024
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
…otnet#102613) There are some cases where an event may be marked by something that is not an IMemberDefinition, for example, an assembly level attribute. dotnet#102528 made an assumption that this was not possible and threw in those cases. This reverts the change related to that assumption. Co-authored-by: Sven Boemer <[email protected]>
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
) Adds a regression test for the issue that was fixed in dotnet#102613. The assembly level attribute marks the members on the referenced type, and the assembly is the MessageOrigin for the marking. I confirmed this fails with before dotnet#102613.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From dotnet/sdk#41096 (comment).
Should fix the issues arising in dotnet/sdk#41096. We should follow this up with a test that exercises this code path.