-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Sve.StoreNarrowing() #102605
Add support for Sve.StoreNarrowing() #102605
Conversation
Note regarding the
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
@a74nh @kunalspathak @dotnet/arm64-contrib @arch-arm64-sve |
Added two separate commits
|
can you please confirm the result of stress test? |
Stress tests look good. Test results
|
Are you using the latest copy of stress script that fixed the problem where we were not passing the environment variables correctly? |
Hi Kunal, I had used the python script version from the 16th May. Tests are failing
|
Most of the failures are related to lack of predicate register support. We are still not saving/restoring callee trash predicate registers and hence when we reuse on of the predicate register that was populated before a method call, it is zeroed out and hence the data we load is all 0, that I can see in the results. As long as there are no JIT asserts, we should be good. When I add predicate register support (which I am working on), we will come back to these failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add Sve.StoreNarrowing() * Incorporate review comments for Sve.StoreAndZip() * Fix formatting issues
Contribute towards #99957.