-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] emscripten bump 3.1.56 #100334
[wasm] emscripten bump 3.1.56 #100334
Changes from 53 commits
e52f7df
a91ec44
d23f6fa
9848b92
50dfb72
aca6c58
f229a30
f917ea6
a7c4e55
0b030c1
6a0057f
6cde92a
1721779
fe1e5c6
3f8834f
123767a
e3b1316
7d6edc3
15bd585
92b4559
d7b1d52
3593c41
4530edf
200cf3b
6e86cc3
02fb272
c313fa5
253ebf9
0d7708b
8a12f44
fc6ad97
683bd51
b15fd5c
9ae3c2f
60a4799
4dadd6d
3bd6bfb
16866a1
d53aaa3
6765913
4c69c36
c268a87
d1d8619
abe9b00
63087a5
d5a0bc4
5d9a6d2
8505fd5
3fe1e1f
b2655bf
ba1ad20
009e371
9e0d5ce
061f2b5
8ed7bf9
d665bfa
fdbb1f2
ddc4698
e6426d2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -177,6 +177,6 @@ jobs: | |
|
||
# Browser WebAssembly windows | ||
- ${{ if in(parameters.platform, 'browser_wasm_win', 'wasi_wasm_win') }}: | ||
- (Windows.Amd64.Server2022.Open)[email protected]/dotnet-buildtools/prereqs:windowsservercore-ltsc2022-helix-webassembly | ||
- (Windows.Amd64.Server2022.Open)[email protected]/dotnet-buildtools/prereqs:windowsservercore-ltsc2022-helix-webassembly-20240702174122-7aba2af | ||
|
||
${{ insert }}: ${{ parameters.jobParameters }} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ | |
</PropertyGroup> | ||
<PropertyGroup Condition="'$(TargetOS)' == 'browser'"> | ||
<_WasmPThreadPoolUnusedSize>10</_WasmPThreadPoolUnusedSize> | ||
<XunitShowProgress>true</XunitShowProgress> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I filled #104418 I hope we can pinpoint more specific root cause with your |
||
</PropertyGroup> | ||
<ItemGroup> | ||
<Compile Include="Helpers.cs" /> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
3.1.34 | ||
3.1.56 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,7 +44,7 @@ set(ignoreMeEmsdkPath "${EMSDK_PATH}") | |
|
||
if(CMAKE_BUILD_TYPE STREQUAL "Release") | ||
add_custom_command(TARGET dotnet.native | ||
POST_BUILD COMMAND ${EMSDK_PATH}/bin/wasm-opt --enable-exception-handling ${CONFIGURATION_WASM_OPT_FLAGS} --strip-dwarf ${NATIVE_BIN_DIR}/dotnet.native.wasm -o ${NATIVE_BIN_DIR}/dotnet.native.wasm | ||
POST_BUILD COMMAND ${EMSDK_PATH}/bin/wasm-opt --enable-exception-handling --enable-simd --enable-bulk-memory ${CONFIGURATION_WASM_OPT_FLAGS} --strip-dwarf ${NATIVE_BIN_DIR}/dotnet.native.wasm -o ${NATIVE_BIN_DIR}/dotnet.native.wasm | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe on different PR, but could we split dwarf into separate file instead of stripping it ? |
||
COMMENT "Stripping debug symbols from dotnet.native.wasm using wasm-opt") | ||
endif() | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
if (_nativeModuleLoaded) throw new Error("Native module already loaded"); | ||
_nativeModuleLoaded = true; | ||
createDotnetRuntime = Module = createDotnetRuntime(Module); | ||
createDotnetRuntime = Module = moduleArg(Module); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to keep this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will be removed once the dependencies are in the flow