Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of PAL versions of floor, floorf, log, modf and modff has broken PAL test suite #98295

Closed
janvorli opened this issue Feb 12, 2024 · 1 comment · Fixed by #98301
Closed

Removal of PAL versions of floor, floorf, log, modf and modff has broken PAL test suite #98295

janvorli opened this issue Feb 12, 2024 · 1 comment · Fixed by #98301
Labels
area-PAL-coreclr
Milestone
9.0.0

Comments

@janvorli
Copy link
Member

While the test sources were removed, the test info for these was not removed from the pal/tests/palsuite/paltestlist.txt.
@janvorli janvorli added this to the 9.0.0 milestone Feb 12, 2024
@janvorli
Copy link
Member Author

cc: @jkoritzinsky

janvorli added a commit to janvorli/runtime that referenced this issue Feb 12, 2024
@janvorli
Fix PAL tests break
d3c27f5 
The recent removal of PAL versions of floor, floorf, log, modf and modff
has broken PAL test suite. While the test sources were removed, the test
info for these was not removed from the
pal/tests/palsuite/paltestlist.txt.

This change fixes it.

Close dotnet#98295
@janvorli janvorli mentioned this issue Feb 12, 2024
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 12, 2024
janvorli added a commit that referenced this issue Feb 12, 2024
@janvorli
Fix PAL tests break (#98301)
75c4371 
The recent removal of PAL versions of floor, floorf, log, modf and modff
has broken PAL test suite. While the test sources were removed, the test
info for these was not removed from the
pal/tests/palsuite/paltestlist.txt.

This change fixes it.

Close #98295
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-PAL-coreclr
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Fix PAL tests break janvorli/runtime
1 participant
@janvorli