Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[superpmi-collect] Widespread failures during collection #98287

Closed
jakobbotsch opened this issue Feb 12, 2024 · 1 comment · Fixed by #98289
Closed

[superpmi-collect] Widespread failures during collection #98287

jakobbotsch opened this issue Feb 12, 2024 · 1 comment · Fixed by #98289
Assignees
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone

Comments

@jakobbotsch
Copy link
Member

superpmi-collect has many failures during collection. Started failing recently (within the past two weeks). The typical failure mode looks like:

18:34:01.847 Running test: JIT/Directed/nullabletypes/isinst2_r/isinst2_r.dll

Assert failure(PID 4124 [0x0000101c], Thread: 3356 [0x0d1c]): The 'LastThrownObject' should not be, but is, NULL.
The runtime may have lost track of the type of an exception in flight.
Please get a good stack trace, find the caller of Validate, and file a bug against the owner.

To suppress this assert 'set DOTNET_SuppressLostExceptionTypeAssert=1'

CORECLR! CLRLastThrownObjectException::Validate + 0x2F6 (0x00007ffb`58b672b6)
CORECLR! `TieredCompilationManager::CompileCodeVersion'::`1'::catch$12 + 0xC4 (0x00007ffb`5925ad54)
CORECLR! CallSettingFrame_LookupContinuationIndex + 0x20 (0x00007ffb`591a20a0)
CORECLR! _FrameHandler4::CxxCallCatchBlock + 0x1DE (0x00007ffb`5919ffde)
NTDLL! RtlCaptureContext + 0x3C3 (0x00007ffb`89839f03)
CORECLR! TieredCompilationManager::CompileCodeVersion + 0x212 (0x00007ffb`58af8022)
CORECLR! TieredCompilationManager::OptimizeMethod + 0xF7 (0x00007ffb`58af9de7)
CORECLR! TieredCompilationManager::DoBackgroundWork + 0x577 (0x00007ffb`58af8997)
CORECLR! TieredCompilationManager::BackgroundWorkerStart + 0x207 (0x00007ffb`58af7ce7)
CORECLR! TieredCompilationManager::BackgroundWorkerBootstrapper1 + 0xDD (0x00007ffb`58af7a7d)
    File: D:\a\_work\1\s\src\coreclr\vm\clrex.cpp:2155
    Image: C:\h\w\BBD509C9\p\corerun.exe

A lot of the test cases look cast related, cc @EgorBo -- I wonder if there's some bug in the SPMI shim around some of the JIT-EE APIs used in the new cast work.
cc @dotnet/jit-contrib

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Feb 12, 2024
jakobbotsch added a commit to jakobbotsch/runtime that referenced this issue Feb 12, 2024
When we see a cast helper here there is no 'this' argument.

Fix dotnet#98287
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 12, 2024
@jakobbotsch jakobbotsch self-assigned this Feb 12, 2024
@jakobbotsch jakobbotsch removed the untriaged New issue has not been triaged by the area owner label Feb 12, 2024
@jakobbotsch jakobbotsch added this to the 9.0.0 milestone Feb 12, 2024
@jakobbotsch jakobbotsch added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed area-TieredCompilation-coreclr labels Feb 12, 2024
@ghost
Copy link

ghost commented Feb 12, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

superpmi-collect has many failures during collection. Started failing recently (within the past two weeks). The typical failure mode looks like:

18:34:01.847 Running test: JIT/Directed/nullabletypes/isinst2_r/isinst2_r.dll

Assert failure(PID 4124 [0x0000101c], Thread: 3356 [0x0d1c]): The 'LastThrownObject' should not be, but is, NULL.
The runtime may have lost track of the type of an exception in flight.
Please get a good stack trace, find the caller of Validate, and file a bug against the owner.

To suppress this assert 'set DOTNET_SuppressLostExceptionTypeAssert=1'

CORECLR! CLRLastThrownObjectException::Validate + 0x2F6 (0x00007ffb`58b672b6)
CORECLR! `TieredCompilationManager::CompileCodeVersion'::`1'::catch$12 + 0xC4 (0x00007ffb`5925ad54)
CORECLR! CallSettingFrame_LookupContinuationIndex + 0x20 (0x00007ffb`591a20a0)
CORECLR! _FrameHandler4::CxxCallCatchBlock + 0x1DE (0x00007ffb`5919ffde)
NTDLL! RtlCaptureContext + 0x3C3 (0x00007ffb`89839f03)
CORECLR! TieredCompilationManager::CompileCodeVersion + 0x212 (0x00007ffb`58af8022)
CORECLR! TieredCompilationManager::OptimizeMethod + 0xF7 (0x00007ffb`58af9de7)
CORECLR! TieredCompilationManager::DoBackgroundWork + 0x577 (0x00007ffb`58af8997)
CORECLR! TieredCompilationManager::BackgroundWorkerStart + 0x207 (0x00007ffb`58af7ce7)
CORECLR! TieredCompilationManager::BackgroundWorkerBootstrapper1 + 0xDD (0x00007ffb`58af7a7d)
    File: D:\a\_work\1\s\src\coreclr\vm\clrex.cpp:2155
    Image: C:\h\w\BBD509C9\p\corerun.exe

A lot of the test cases look cast related, cc @EgorBo -- I wonder if there's some bug in the SPMI shim around some of the JIT-EE APIs used in the new cast work.
cc @dotnet/jit-contrib

Author: jakobbotsch
Assignees: jakobbotsch
Labels:

area-CodeGen-coreclr, in-pr

Milestone: 9.0.0

jakobbotsch added a commit that referenced this issue Feb 12, 2024
#98289)

When we see a cast helper here there is no 'this' argument.

Fix #98287
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant