Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide ALC name in DispatchProxy for proxies in custom ALC #82969

Closed
buyaa-n opened this issue Mar 4, 2023 · 1 comment · Fixed by #92385
Closed

Provide ALC name in DispatchProxy for proxies in custom ALC #82969

buyaa-n opened this issue Mar 4, 2023 · 1 comment · Fixed by #92385
Labels
area-System.Reflection help wanted [up-for-grabs] Good issue for external contributors
Milestone
9.0.0

Comments

@buyaa-n
Copy link
Contributor

buyaa-n commented Mar 4, 2023

With #62095 issues with proxies loaded from custom ALC is fixed and the ALC name was passed to the AssemblyName used for creating the Proxy type, but that was causing issues for ALC that include paths in its name. We reverted that part as it was causing a regression.

Though passing ALC name to the proxy assembly could be useful for debugging purposes and @jkotas suggested a good way for fixing it in #82807 (comment):
@buyaa-n buyaa-n added this to the 8.0.0 milestone Mar 4, 2023
@ghost
Copy link

ghost commented Mar 4, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

With #62095 issues with proxies loaded from custom ALC is fixed and the ALC name was passed to the AssemblyName used for creating the Proxy type, but that was causing issues for ALC that include paths in its name. We reverted that part as it was causing a regression.

Though passing ALC name to the proxy assembly could be useful for debugging purposes and @jkotas suggested a good way for fixing it in #82807 (comment):

Author: buyaa-n
Assignees: -
Labels:

area-System.Reflection
Milestone: 8.0.0

@buyaa-n buyaa-n mentioned this issue Mar 4, 2023
Merged
2 tasks
@steveharter steveharter added the help wanted [up-for-grabs] Good issue for external contributors label Jul 24, 2023
@steveharter steveharter modified the milestones: 8.0.0, 9.0.0 Aug 11, 2023
@pedrobsaila pedrobsaila mentioned this issue Sep 20, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Sep 20, 2023
jkotas pushed a commit that referenced this issue Sep 22, 2023
@pedrobsaila
Provide ALC name in DispatchProxy for proxies in custom ALC (#92385)
b842334 
Fixes #82969
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Sep 22, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Reflection help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Provide ALC name in DispatchProxy for proxies in custom ALC pedrobsaila/runtime
2 participants
@steveharter @buyaa-n