Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NativeAOT ICU build integration for Apple mobile platforms #82389

Closed
Tracked by #81024
ivanpovazan opened this issue Feb 20, 2023 · 2 comments · Fixed by #82393
Closed
Tracked by #81024

Fix NativeAOT ICU build integration for Apple mobile platforms #82389

ivanpovazan opened this issue Feb 20, 2023 · 2 comments · Fixed by #82393
Labels
area-NativeAOT-coreclr os-ios Apple iOS
Milestone
8.0.0

Comments

@ivanpovazan
Copy link
Member

ivanpovazan commented Feb 20, 2023 •
edited
Loading

Description

Currently System.Globalization.Native is not being built as part of the build process for targeting Apple mobile platforms with NativeAOT. This implies that applications have to use invariant globalization mode.

Proposal

Support building System.Globalization.Native with NativeAOT when targeting mobile platforms and adjust build integration targets according to the fix:

runtime/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets

Line 67 in 06dd126

<NetCoreAppNativeLibrary Include="System.Globalization.Native" Condition="'$(StaticICULinking)' != 'true' and '$(_IsiOSLikePlatform)' != 'true'" />

Until this is fixed, make sure that applications set: InvariantGlobalization=true
@ivanpovazan ivanpovazan mentioned this issue Feb 20, 2023
Closed
4 tasks
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Feb 20, 2023
@ivanpovazan ivanpovazan changed the title Fix ICU build integration Fix NativeAOT ICU build integration for Apple mobile platforms Feb 20, 2023
@ivanpovazan ivanpovazan added area-NativeAOT-coreclr and removed untriaged New issue has not been triaged by the area owner labels Feb 20, 2023
@ghost
Copy link

ghost commented Feb 20, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: ivanpovazan
Assignees: -
Labels:

area-NativeAOT-coreclr
Milestone: -

@ivanpovazan ivanpovazan added the os-ios Apple iOS label Feb 20, 2023
@ghost
Copy link

ghost commented Feb 20, 2023

Tagging subscribers to 'os-ios': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: ivanpovazan
Assignees: -
Labels:

os-ios, area-NativeAOT-coreclr
Milestone: -

This was referenced Feb 20, 2023
Merged
Merged
@marek-safar marek-safar added this to the 8.0.0 milestone Feb 20, 2023
@filipnavara filipnavara mentioned this issue Feb 20, 2023
Merged
@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Feb 20, 2023
@agocke agocke added this to AppModel Mar 6, 2023
akoeplinger added a commit that referenced this issue Apr 25, 2023
@filipnavara @akoeplinger
[mono][NativeAOT] System.Globalization.Native build improvements (#82393
0fc8978 
)

Fixes #82389

- Fixes build of System.Globalization.Native for iOS-like, browser, and wasi platforms
- Removes ICU shim from static builds of Mono runtime and builds it as part of libs.native subset
- Switches browser/wasi to use the static libraries

Co-authored-by: Alexander Köplinger <[email protected]>
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 25, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-NativeAOT-coreclr os-ios Apple iOS
Projects
AppModel
Archived in project
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

[mono][NativeAOT] System.Globalization.Native build improvements filipnavara/runtime
2 participants
@marek-safar @ivanpovazan