Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittent crash in DynamicGenerics test on OSX x64 #73299

Closed
jkotas opened this issue Aug 3, 2022 · 13 comments · Fixed by #76489
Closed

Intermittent crash in DynamicGenerics test on OSX x64 #73299

jkotas opened this issue Aug 3, 2022 · 13 comments · Fixed by #76489
Labels
area-NativeAOT-coreclr disabled-test The test is disabled in source code against the issue
Milestone
8.0.0

Comments

@jkotas
Copy link
Member

jkotas commented Aug 3, 2022 

Running Test: ThreadLocalStatics.TLSTesting.ThreadLocalStatics_Test
Expected: 100
Actual: 134
END EXECUTION - FAILED
Test Harness Exitcode is : 1
To run the test:
> set CORE_ROOT=/Users/runner/work/1/s/artifacts/tests/coreclr/OSX.x64.Release/Tests/Core_Root
> /Users/runner/work/1/s/artifacts/tests/coreclr/OSX.x64.Release/nativeaot/SmokeTests/DynamicGenerics/DynamicGenerics/DynamicGenerics.sh
Expected: True
Actual:   False
Stack Trace:
  /Users/runner/work/1/s/artifacts/tests/coreclr/OSX.x64.Release/TestWrappers/nativeaot.SmokeTests/nativeaot.SmokeTests.XUnitWrapper.cs(347,0): at nativeaot_SmokeTests._DynamicGenerics_DynamicGenerics_DynamicGenerics_._DynamicGenerics_DynamicGenerics_DynamicGenerics_sh()
     at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
     at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Aug 3, 2022
@jkotas
Copy link
Member Author

jkotas commented Aug 3, 2022

Hit in #73271. Full log https://dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_apis/build/builds/1920116/logs/1036

@jkotas jkotas mentioned this issue Aug 3, 2022
Merged
@MichalStrehovsky
Copy link
Member

Also failed in #73131: https://dev.azure.com/dnceng/public/_build/results?buildId=1917271&view=logs&jobId=d0e6dc78-17a8-5646-915d-5d9284339059&j=2de479a8-eae7-5324-c49d-bebaef329288&t=bb577e75-8247-55f1-4164-04f3b0f2d1eb&s=96ac2280-8cb4-5df5-99de-dd2da759617d

@sbomer sbomer added this to AppModel Aug 4, 2022
@vitek-karas vitek-karas added this to the 7.0.0 milestone Aug 4, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Aug 4, 2022
@MichalStrehovsky MichalStrehovsky mentioned this issue Aug 9, 2022
Merged
@MichalStrehovsky
Copy link
Member

Looks like intermitted crash in DynamicGenerics is only a tip of the iceberg. I did a libraries test pass on mac in #73546 and it's a crashfest.

Moving this to 8.0. Mac is not supported.

@MichalStrehovsky MichalStrehovsky modified the milestones: 7.0.0, 8.0.0 Aug 10, 2022
@MichalStrehovsky MichalStrehovsky mentioned this issue Aug 10, 2022
Merged
@MichalStrehovsky MichalStrehovsky added the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Aug 11, 2022
@MichalStrehovsky MichalStrehovsky mentioned this issue Aug 11, 2022
Closed
@jkotas jkotas mentioned this issue Aug 11, 2022
Merged
@runfoapp runfoapp bot mentioned this issue Aug 11, 2022
Closed
@carlossanlop carlossanlop mentioned this issue Aug 25, 2022
Merged
@carlossanlop
Copy link
Member

Hit it in a 7.0 backport: #74589

      nativeaot/SmokeTests/DynamicGenerics/DynamicGenerics/DynamicGenerics.sh [FAIL]
        /Users/runner/work/1/s/src/tests/Common/scripts/nativeaottest.sh: line 14: 22270 Abort trap: 6           $_DebuggerFullPath $1/native/$exename "${@:3}"
        
        Return code:      1
        Raw output file:      /Users/runner/work/1/s/artifacts/tests/coreclr/OSX.x64.Release/nativeaot/SmokeTests/Reports/nativeaot.SmokeTests/DynamicGenerics/DynamicGenerics/DynamicGenerics.output.txt
        Raw output:
        BEGIN EXECUTION
        /Users/runner/work/1/s/src/tests/Common/scripts/nativeaottest.sh /Users/runner/work/1/s/artifacts/tests/coreclr/OSX.x64.Release/nativeaot/SmokeTests/DynamicGenerics/DynamicGenerics/ DynamicGenerics.dll ''
        --------------------------------
        Running Test: My.TestActivatorCreateInstance
        Calling List<My>.ctor
        System.Collections.Generic.List`1[My]
        Adding item to List<My>
        Calling List<My>.get_Count
        Calling GC.Collect
        Calling List<Foo>.ctor
        System.Collections.Generic.List`1[Foo]
        Adding item to List<Foo>
        Calling List<My>.get_Count
        Calling Dictionary<My,My>.ctor
        System.Collections.Generic.Dictionary`2[My,My]
        Adding item to Dictionary<My,My>

Running Test: ThreadLocalStatics.TLSTesting.ThreadLocalStatics_Test
Expected: 100
Actual: 134
END EXECUTION - FAILED
Test Harness Exitcode is : 1
To run the test:
> set CORE_ROOT=/Users/runner/work/1/s/artifacts/tests/coreclr/OSX.x64.Release/Tests/Core_Root
> /Users/runner/work/1/s/artifacts/tests/coreclr/OSX.x64.Release/nativeaot/SmokeTests/DynamicGenerics/DynamicGenerics/DynamicGenerics.sh


Time [secs] | Total | Passed | Failed | Skipped | Assembly Execution Summary
============================================================================
     14.255 |    17 |     16 |      1 |       0 | nativeaot.SmokeTests.XUnitWrapper.dll
----------------------------------------------------------------------------
     14.255 |    17 |     16 |      1 |       0 | (total)

@MichalStrehovsky
Copy link
Member

Blocking the test in #74618. Dropping blocking-clean-ci label.

@MichalStrehovsky MichalStrehovsky removed the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Aug 26, 2022
@jkotas jkotas mentioned this issue Sep 6, 2022
Closed
@filipnavara
Copy link
Member

filipnavara commented Sep 9, 2022 •
edited
Loading

I wonder if the root cause could be similar to #75264 (comment).

@MichalStrehovsky MichalStrehovsky mentioned this issue Sep 22, 2022
Merged
@carlossanlop
Copy link
Member

Found another hit in the release/7.0-rc2->release/7.0 automated merge branch PR: #75913

 --------------------------------
        Running Test: ThreadLocalStatics.TLSTesting.ThreadLocalStatics_Test
        Expected: 100
        Actual: 134
        END EXECUTION - FAILED
        Test Harness Exitcode is : 1
        To run the test:
        > set CORE_ROOT=/Users/runner/work/1/s/artifacts/tests/coreclr/OSX.x64.Release/Tests/Core_Root
        > /Users/runner/work/1/s/artifacts/tests/coreclr/OSX.x64.Release/nativeaot/SmokeTests/DynamicGenerics/DynamicGenerics/DynamicGenerics.sh
        Expected: True
        Actual:   False
        Stack Trace:
          /Users/runner/work/1/s/artifacts/tests/coreclr/OSX.x64.Release/TestWrappers/nativeaot.SmokeTests/nativeaot.SmokeTests.XUnitWrapper.cs(347,0): at nativeaot_SmokeTests._DynamicGenerics_DynamicGenerics_DynamicGenerics_._DynamicGenerics_DynamicGenerics_DynamicGenerics_sh()
             at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
             at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
        Output:
          /Users/runner/work/1/s/src/tests/Common/scripts/nativeaottest.sh: line 14: 62770 Abort trap: 6           $_DebuggerFullPath $1/native/$exename "${@:3}"
          
          Return code:      1
          Raw output file:      /Users/runner/work/1/s/artifacts/tests/coreclr/OSX.x64.Release/nativeaot/SmokeTests/Reports/nativeaot.SmokeTests/DynamicGenerics/DynamicGenerics/DynamicGenerics.output.txt
          Raw output:
          BEGIN EXECUTION
          /Users/runner/work/1/s/src/tests/Common/scripts/nativeaottest.sh /Users/runner/work/1/s/artifacts/tests/coreclr/OSX.x64.Release/nativeaot/SmokeTests/DynamicGenerics/DynamicGenerics/ DynamicGenerics.dll ''
          --------------------------------

@MichalStrehovsky
Copy link
Member

@carlossanlop how much does this bother things in the release branch? We could backport #74618 to make this go away.

@carlossanlop
Copy link
Member

I have seen it intermittently. It would certainly help clean the CI in the long term. How concerning is this issue in general? We could consider it if it meets the bar, besides cleaning the CI.

@jeffschwMSFT thoughts?

@jkotas
Copy link
Member Author

jkotas commented Sep 27, 2022

Let's backport it.

@jkotas
Copy link
Member Author

jkotas commented Sep 27, 2022

#76223

@jkotas jkotas mentioned this issue Sep 27, 2022
Merged
@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Sep 27, 2022
@carlossanlop
Copy link
Member

Do you want to keep this issue open? Or can we consider it fixed after disabling DynamicGenerics from mac in main and 7.0?

@filipnavara
Copy link
Member

filipnavara commented Sep 27, 2022 •
edited
Loading

Keep open with disabled-test label? (It may be fixed in main, or once my WIP PR gets all the tests enabled w/ related fixes)

@filipnavara filipnavara added the disabled-test The test is disabled in source code against the issue label Sep 27, 2022
@markples markples mentioned this issue Sep 30, 2022
Merged
jkotas added a commit to jkotas/runtime that referenced this issue Oct 1, 2022
@jkotas
Re-enable DynamicGenerics test on OSX
8851c3a 
Fixes dotnet#73299
@jkotas jkotas mentioned this issue Oct 1, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Oct 1, 2022
jkotas added a commit that referenced this issue Oct 2, 2022
@jkotas
Re-enable DynamicGenerics test on OSX (#76489)
319391e 
Fixes #73299
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Oct 2, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-NativeAOT-coreclr disabled-test The test is disabled in source code against the issue
Projects
AppModel
Archived in project
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Re-enable DynamicGenerics test on OSX jkotas/runtime
5 participants
@carlossanlop @filipnavara @jkotas @vitek-karas @MichalStrehovsky