Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GVM lookup failure in System.Collections.Immutable test #70878

Closed
MichalStrehovsky opened this issue Jun 17, 2022 · 0 comments · Fixed by #71524
Closed

GVM lookup failure in System.Collections.Immutable test #70878

MichalStrehovsky opened this issue Jun 17, 2022 · 0 comments · Fixed by #71524
Labels
area-NativeAOT-coreclr
Milestone
7.0.0

Comments

@MichalStrehovsky
Copy link
Member

Process terminated. Generic virtual method pointer lookup failure.

Declaring type handle: MethodTable:0x00007FF7EB374580
Target type handle: MethodTable:0x00007FF7EB3744F0
Method name: Empty
Instantiation:
Argument 00000000: MethodTable:0x00007FF7EB33DC68
Argument 00000001: MethodTable:0x00007FF7EB3743F0
@MichalStrehovsky MichalStrehovsky added this to the 7.0.0 milestone Jun 17, 2022
@agocke agocke added this to AppModel Jun 27, 2022
MichalStrehovsky added a commit to MichalStrehovsky/runtime that referenced this issue Jul 1, 2022
@MichalStrehovsky
Implement type loader support for thread statics
fa0fac5 
We do threadstatics differently from .NET Native and this wasn't implemented.

Fixes dotnet#70878 that was reaching a failfast because we couldn't build the target of GVM dispatch at runtime due to unhandled dictionary cell.

I've homed the threadstatic bases under the type manager of the template type. We could potentially make a new type manager, but they currently use this one.

Deleted some more .NET Native leftovers.

Had to update the DynamicGeneric test RD.XML because the test was assuming .NET Native behavior where the ctors are always kept on types that escape the dataflow analysis.
@MichalStrehovsky MichalStrehovsky mentioned this issue Jul 1, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 1, 2022
MichalStrehovsky added a commit that referenced this issue Jul 4, 2022
@MichalStrehovsky
Implement type loader support for thread statics (#71524)
7496163 
We do threadstatics differently from .NET Native and this wasn't implemented.

Fixes #70878 that was reaching a failfast because we couldn't build the target of GVM dispatch at runtime due to unhandled dictionary cell.

I've homed the threadstatic bases under the type manager of the template type. We could potentially make a new type manager, but they currently use this one.

Deleted some more .NET Native leftovers.

Had to update the DynamicGeneric test RD.XML because the test was assuming .NET Native behavior where the ctors are always kept on types that escape the dataflow analysis.
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 4, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-NativeAOT-coreclr
Projects
AppModel
Archived in project
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Implement type loader support for thread statics MichalStrehovsky/runtime
1 participant
@MichalStrehovsky