Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Text.Json.Nodes.Tests.OperatorTests.ExplicitOperators_FromValues failing on Android x86 in rolling build of runtime-extra-platforms #69800

Open
mkhamoyan opened this issue May 25, 2022 · 9 comments

Comments

@mkhamoyan
Copy link
Contributor

Description

In last rolling build of runtime-extra-platforms System.Text.Json.Nodes.Tests.OperatorTests.ExplicitOperators_FromValues test is failing with following exception at System.Text.Json.Nodes.Tests.OperatorTests.ExplicitOperators_FromValues() in /_/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonNode/JsonNodeOperatorTests.cs:line 105
at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)

Assert.Equal() Failure
Expected: NaN
Actual: 2.2000000000000002

Reproduction Steps

Check last rolling build of runtime-extra-platforms

Expected behavior

System.Text.Json.Nodes.Tests.OperatorTests.ExplicitOperators_FromValues should pass.

Actual behavior

System.Text.Json.Nodes.Tests.OperatorTests.ExplicitOperators_FromValues is failing.

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 25, 2022
@ghost
Copy link

ghost commented May 25, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

In last rolling build of runtime-extra-platforms System.Text.Json.Nodes.Tests.OperatorTests.ExplicitOperators_FromValues test is failing with following exception at System.Text.Json.Nodes.Tests.OperatorTests.ExplicitOperators_FromValues() in /_/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonNode/JsonNodeOperatorTests.cs:line 105
at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)

Assert.Equal() Failure
Expected: NaN
Actual: 2.2000000000000002

Reproduction Steps

Check last rolling build of runtime-extra-platforms

Expected behavior

System.Text.Json.Nodes.Tests.OperatorTests.ExplicitOperators_FromValues should pass.

Actual behavior

System.Text.Json.Nodes.Tests.OperatorTests.ExplicitOperators_FromValues is failing.

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Author: mkhamoyan
Assignees: -
Labels:

area-System.Text.Json, untriaged

Milestone: -

@mkhamoyan
Copy link
Contributor Author

From commit history only things that more or less can be related maybe are these PRs #69326 and #69768, @MichalStrehovsky , @eiriktsarpalis could you please take a look? can these PRs be related?

@eiriktsarpalis
Copy link
Member

According to the test results the following assertion is failing:

For whatever reason the error message states that the expected value is NaN, even though this is clearly not the expected argument being passed to the assertion. I don't think it's related to JSON changes.

@eiriktsarpalis eiriktsarpalis added the runtime-mono specific to the Mono runtime label May 25, 2022
@MichalStrehovsky
Copy link
Member

#69768

This affected file is not included from Mono, so I'm 100% sure it's unrelated.

@mkhamoyan
Copy link
Contributor Author

Seems the failure was sporadic, not available on new build.
I will wait for one more rolling build and if everything good will close the issue.

@eiriktsarpalis
Copy link
Member

Should this be closed now?

@ghost
Copy link

ghost commented Jun 16, 2022

Tagging subscribers to 'arch-android': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

In last rolling build of runtime-extra-platforms System.Text.Json.Nodes.Tests.OperatorTests.ExplicitOperators_FromValues test is failing with following exception at System.Text.Json.Nodes.Tests.OperatorTests.ExplicitOperators_FromValues() in /_/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonNode/JsonNodeOperatorTests.cs:line 105
at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)

Assert.Equal() Failure
Expected: NaN
Actual: 2.2000000000000002

Reproduction Steps

Check last rolling build of runtime-extra-platforms

Expected behavior

System.Text.Json.Nodes.Tests.OperatorTests.ExplicitOperators_FromValues should pass.

Actual behavior

System.Text.Json.Nodes.Tests.OperatorTests.ExplicitOperators_FromValues is failing.

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Author: mkhamoyan
Assignees: -
Labels:

area-System.Text.Json, os-android, untriaged, runtime-mono

Milestone: -

@karelz karelz added the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Jun 16, 2022
@karelz
Copy link
Member

karelz commented Jun 16, 2022

This is still happening - see runfo

  • 6/15 - 10 failures (6 in rolling test runs, 4 in PRs) in last 7 days
    • 24 failures in last 30 days - 12 failures in rolling test runs

Given the impact, can we please disable the test ASAP on Android? @steveisok

mkhamoyan added a commit to mkhamoyan/runtime that referenced this issue Jun 22, 2022
mkhamoyan added a commit to mkhamoyan/runtime that referenced this issue Jun 22, 2022
mkhamoyan added a commit that referenced this issue Jun 23, 2022
* #69800 add conditionalFact to skip android x86
@karelz
Copy link
Member

karelz commented Jun 24, 2022

Test is disabled now - thanks @mkhamoyan! Not blocking CI anymore.

@karelz karelz removed the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Jun 24, 2022
@steveisok steveisok removed the untriaged New issue has not been triaged by the area owner label Jul 5, 2022
@steveisok steveisok added this to the Future milestone Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants