Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Fix new compiler warnings in the native code #69142

Closed
radekdoulik opened this issue May 10, 2022 · 2 comments
Closed

[wasm] Fix new compiler warnings in the native code #69142

radekdoulik opened this issue May 10, 2022 · 2 comments
Assignees
@radekdoulik
Labels
arch-wasm WebAssembly architecture area-Build-mono
Milestone
7.0.0

Comments

@radekdoulik
Copy link
Member

Emscripten's 3.1.9 clang is again more strict. In #68765 I silence these warning temporarily with:

-Wno-strict-prototypes
-Wno-unused-but-set-variable

We should properly fix them.
@radekdoulik radekdoulik added this to the 7.0.0 milestone May 10, 2022
@radekdoulik radekdoulik self-assigned this May 10, 2022
@radekdoulik radekdoulik mentioned this issue May 10, 2022
Closed
@radical radical added the arch-wasm WebAssembly architecture label May 13, 2022
@ghost
Copy link

ghost commented May 13, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Emscripten's 3.1.9 clang is again more strict. In #68765 I silence these warning temporarily with:

-Wno-strict-prototypes
-Wno-unused-but-set-variable

We should properly fix them.

Author: radekdoulik
Assignees: radekdoulik
Labels:

arch-wasm, area-Build-mono
Milestone: 7.0.0

@radekdoulik radekdoulik mentioned this issue Jun 27, 2022
Merged
radekdoulik added a commit to radekdoulik/runtime that referenced this issue Jul 20, 2022
@radekdoulik
[wasm] Fix no-unused-but-set-variable warnings
09644df 
And enable it again. This fixes part of dotnet#69142
@radekdoulik radekdoulik mentioned this issue Jul 20, 2022
Closed
@radekdoulik
Copy link
Member Author

Zoltan thinks these are harmless, so lets keep them disabled.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@radekdoulik radekdoulik

Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
2 participants
@radical @radekdoulik